Closed emily-humphreys closed 2 years ago
@emily-humphreys @SishaMish
Changes are on staging and ready for QA. Image size has been reduced (see below):
You can invite yourself as a user by visiting the "Users" side bar option, clicking the [+ Invite]
button and entering a new user's details, but at a +n to your email address (e.g. ferrisoxide+1@gmail.com). NB This will only work for Gmail-based email addresses. The invitation email will be sent to your normal address.
By verifying this ticket you are also verifying the MUST allow emails to be sent via the app for account confirmation (i.e. via Mandrill)
criteria of ticket #793
This should probably be checked in a proper email client (MS Outlook, Apple Mail, etc) to verify the HTML email is rendering correctly
@ferrisoxide @emily-humphreys
This has bee QA'd and passed.
Steps taken:
Deployed to production. Closing.
Reopening as it - looks like this hasn't been deployed.
Can we check all URLs in email to ensure they are .co/html
@emily-humphreys
Can we check all URLs in email to ensure they are .co/html
Not all links point back to .co - the "accept invitation" link and the "tool for systematic change" both point the app. The first one has to - it's the confirmation link the app needs to log someone in for the first time. The "tool for systematic change" link can point to your .co page if you like, but you'd need to tell me what URL you want to use.
I've just checked the invitation system and that appears to be working. The links that point to the app behave appropriately, including the "accept invitation" link.
The only link that doesn't work is the link to the User Guides. It points to https://www.wickedlab.co/help.html - that's on your web page. I'm sure pretty that link used to work - has that "Help" page been deleted? If the "User guides" page has changed, what should it be now?
What links were returning 404s for the client? All the links, or just the link to user guide?
@emily-humphreys
Scratch that. My apologies. I'll look into what has happened. I don't think it's "all" links, but yes the ULRs are incorrect for the guides.
@emily-humphreys @SishaMish
OK, it wasn't "all" links - the forwarded email has links you can follow, so I'm not sure that the customer reported that correctly. The only link that has problems is the user guide link - that's my fault. Not sure how we missed it, but it never got updated.
As for the image size, different email clients behave differently. GMail and Apple mail were rendering the image correctly, but it looks like the Microsoft Mail client does not. I've changed this to use a smaller image, so it won't matter what the receiving client tries to do with it.
For the record, the changes were deployed. There were two issues however:
Going forward, I've pushed changes directly to production that should fix the issue. Lisa and I will also have to take care in future, and make sure we cover the spec as it's written.
@emily-humphreys @SishaMish
I've verified that the invitation process is working. Images are smaller in MS Mail, look fine in GMail. Link to the user guides points to the correct URL on the www.wickedlab.co
domain. All other links point to correct URLs on the app.wickedlab.com.au
domain.
@emily-humphreys @SishaMish
This is on staging (and prod) and ready for QA. The criteria to check invitation emails against:
This is all perfect and meets all criteria. Ready for production
On Wed, Oct 5, 2022 at 12:22 PM Tom Tuddenham @.***> wrote:
@emily-humphreys https://github.com/emily-humphreys @SishaMish https://github.com/SishaMish
This is on staging (and prod) and ready for QA. The criteria to check invitation emails against:
- footer image displays correctly in different email clients (e.g. GMail, Apple Mail, Microsoft Mail on Windows)
- link to user guides works, going to https://www.wickedlab.co/help-guides
- confirmation link works, going to user confirmation page and allows user to set their password
— Reply to this email directly, view it on GitHub https://github.com/ferrisoxide/wicked_software/issues/792#issuecomment-1267811841, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFVZOXZBXGZC2X57YJ663DWBTNMXANCNFSM56CTCIJA . You are receiving this because you were mentioned.Message ID: @.***>
Deployed. Closing
Describe the task
Update User Invitation Email with new User Help url and make Wicked Lab logo small
Success Criteria
User Invitation email is updated with new URL
You can access User Guides here direct to https://www.wickedlab.co/help-guides]
Wicked Lab logo is updated to small logo (replacing large logo)
(note can we make the logo even smaller or do you need a new png file)?