EventideSystems / tool_for_systemic_change

GNU Affero General Public License v3.0
3 stars 0 forks source link

Upgrade to Ruby 3 #931

Closed ferrisoxide closed 9 months ago

ferrisoxide commented 9 months ago

Description

Upgrade Ruby from the obsolete 2.7.7 version to 3.1.4.

Acceptance Criteria

ferrisoxide commented 9 months ago

NOTES TO QA

@SishaMish

This is an important upgrade to the application, changing the version of Ruby used from the now obsolete 2.7.7 to 3.1.4.

We need to make sure this doesn't introduce any regressions. I've smoke tested most of the application myself, but my main concern is reports as I can never get my head around them. QA should focus there.

NB This also fixes an issue with the "Your license to the Wicked Lab tool for Systemic Change has expired" message when a user tries to log on to an account that has expired. The email address was still pointing to wickedlab - now uses "hello@toolforsystemicchange.com". This should be checked as well.

SishaMish commented 9 months ago

Accessing expired account

@ferrisoxide

I have tested accessing an account that has expired and the issue has been fixed.

Image

SishaMish commented 9 months ago

Reports MUST work as before

@ferrisoxide

I have tested all of the reports and compared them to reports that were run at an earlier date.

Stakeholder report :+1:

Subsystem Report :+1:

Comments Report :+1:

Activity Report :-1:

Image

Image

Image

Image

ferrisoxide commented 9 months ago

@SishaMish I've reset the staging environment back to how it was pre Ruby 3. Let's baseline some reports and then re-run them again after upgrading so we can guarantee like for like comparison.

ferrisoxide commented 9 months ago

@SishaMish As an aside, that report had some activity on 2023-06-18 so there may be data that alters things - especially if it's on the boundary of one day or the other.

SishaMish commented 9 months ago

@ferrisoxide

I have retested the Activity Report with the correct dates, and all totals are as expected.

This is a pass :+1:

I have checked the functionality of the app including:

Everything works as expected.

This is a pass 👍

ferrisoxide commented 9 months ago

Deployed. Closing.