Everyplay / everyplay-ios-sdk

Everyplay SDK for iOS
https://developers.everyplay.com
92 stars 31 forks source link

Missing method for querying if recording is enabled #17

Closed butaca closed 10 years ago

butaca commented 10 years ago

I disabled single core recording with [[[Everyplay sharedInstance] capture] disableSingleCoreDevices] and [[[Everyplay sharedInstance] capture] isRecordingSupported] returns true on single core devices even though it is disabled. At first I thought it was a bug, but is only a matter of semantics, because in fact is supported but disabled. However I didn't find a way to check if recording was enabled, so I have to keep my own flag when calling disableSingleCoreDevices and use isSingleCoreDevice.

I think it the API should expose a higher level method to query for that information (is recording enabled?) and don't delegate that to the user.

aet commented 10 years ago

disableSingleCoreDevices is a @property getter/setter, just calling [[[Everyplay sharedInstance] capture] disableSingleCoreDevices] tries to look up it's value instead disabling something.

Call [[Everyplay sharedInstance] capture].disableSingleCoreDevices = YES; instead

butaca commented 10 years ago

Sorry about that.

The "disableSingleCoreDevices" naming implies a method because it is an action. Maybe that property should be called singleCoreRecordingEnabled, or something similar.

Thanks.