Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.86k forks source link

[On Hold] Improve error message when a debit card is added #12913

Closed marcochavezf closed 10 months ago

marcochavezf commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  1. In NewDot sign in with an expensifail account
  2. Click on the Avatar icon (Settings) -> Payments -> Add Payment method -> Debit card
  3. Fill in the form and for the card number enter a valid non-debit testing card like 4111111111111111

Expected Result:

A descriptive error message should be shown.

Actual Result:

The error Auth CreateFund returned an error is shown. eg: conor@expensifail.com, getting these logs with the error showing as 400 Invalid debit card

Workaround:

We could look up the logs for the user to find the error message and communicate that to the customer to solve

Platform:

Where is this issue occurring?

Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

203069941-eba69df7-7444-4d02-9a9a-c76ebc67ca43
melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

conorpendergrast commented 1 year ago

From this SO: https://stackoverflow.com/c/expensify/questions/14418

melvin-bot[bot] commented 1 year ago

@conorpendergrast, @marcochavezf Huh... This is 4 days overdue. Who can take care of this?

conorpendergrast commented 1 year ago

Confirming Bug0 steps for Internal issues via Slack, and then will take those here!

conorpendergrast commented 1 year ago

Hah, @marcochavezf has confirmed that he is working on a PR for the issue. Marco, can you link the draft PR to this issue?

marcochavezf commented 1 year ago

PR up to be reviewed, but on hold because of the Bancorp routing configuration.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @rosegrech (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

marcochavezf commented 1 year ago

Hi @rosegrech, just gut-checking if the copy for the error message when a user enters a non-debit card is fine (Make sure the entered debit card is a valid one):

Screenshot 2022-11-28 at 23 12 58
rosegrech commented 1 year ago

sure thing, this is a bit smoother:

Make sure the debit card you entered is valid.

conorpendergrast commented 1 year ago

Do we have any idea what makes a debit card "valid" or "not valid"?

rosegrech commented 1 year ago

@marcochavezf ^^

marcochavezf commented 1 year ago

Do we have any idea what makes a debit card "valid" or "not valid"?

We only allow debit cards for this flow, and there's a possibility that the user could enter a credit or pre-paid card.

conorpendergrast commented 1 year ago

Ah ok, got it, so there's two possibilities:

  1. They've entered an invalid debit card
  2. They've entered something that isn't debit card

Make sure the debit card you entered is valid.

Seems to address 1 fine, but it's a little subtle on 2. @rosegrech what do you think on

Make sure you've entered a valid debit card.

It's a very slight rewording, but should emphasise that it has to be valid, and a debit card

rosegrech commented 1 year ago

Great detective work Conor!

marcochavezf commented 1 year ago

Cool, then Make sure you've entered a valid debit card. will be the final copy, thanks!

Additionally, I'm going to put this one on hold until we are able to communicate with Bancorp sandbox API to use test debit cards on staging/production, otherwise, Applause won't be able to test the fix when the PR is deployed.

conorpendergrast commented 1 year ago

I'm re-assigning to another BugZero team member in case there are any further steps, as I'm going on sabbatical in 30 minutes!

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

conorpendergrast commented 1 year ago

@isabelastisser Nothing needed her for now, assigning you in case there's any follow-up questions from @marcochavez for anything else

isabelastisser commented 1 year ago

Not overdue.

isabelastisser commented 1 year ago

Not overdue.

isabelastisser commented 1 year ago

Not overdue.

isabelastisser commented 1 year ago

Not overdue, changing this to weekly.

marcochavezf commented 1 year ago

Not overdue

marcochavezf commented 1 year ago

Still waiting on Bancorp's response. I'm going to use this issue to post updates about it.

isabelastisser commented 1 year ago

Not overdue.

isabelastisser commented 1 year ago

Internal; not overdue.

isabelastisser commented 1 year ago

Internal, can I change this to Monthly? @marcochavezf

marcochavezf commented 1 year ago

Ah yeah, that's fine. I hope to continue with this one soon (updates here).

marcochavezf commented 1 year ago

No updated, focused on EYOC MVP this week

marcochavezf commented 1 year ago

No updated, focused on EYOC MVP this week

marcochavezf commented 1 year ago

No updated, focused on EYOC MVP this week

marcochavezf commented 1 year ago

Coming back from ECX, I will give priority to the Bancorp token for staging this week

marcochavezf commented 1 year ago

Still on hold

marcochavezf commented 1 year ago

Still on hold

isabelastisser commented 1 year ago

Not overdue, on hold!

isabelastisser commented 1 year ago

Not overdue, on hold.

marcochavezf commented 1 year ago

Removing the hold title since the debit test cards are not working on staging. I will work on this one in spare cycles

slafortune commented 1 year ago

👋 hey, quick note that we should keep all e/app GHs as daily unless they have "Hold" in the title. I'm going to flip this back to daily as I'm doing the resync and it's step in the SO process guide.

isabelastisser commented 1 year ago

Internal!

isabelastisser commented 1 year ago

Not overdue, internal!

melvin-bot[bot] commented 1 year ago

@marcochavezf, @isabelastisser, @rosegrech Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

marcochavezf commented 1 year ago

Not overdue, focused on unauthenticated users in public rooms implementation for RenderATL

melvin-bot[bot] commented 1 year ago

@marcochavezf, @isabelastisser, @rosegrech Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 1 year ago

@marcochavezf, @isabelastisser, @rosegrech Eep! 4 days overdue now. Issues have feelings too...

marcochavezf commented 1 year ago

Not overdue, focused on unauthenticated users in public rooms implementation for RenderATL

melvin-bot[bot] commented 1 year ago

@marcochavezf, @isabelastisser, @rosegrech Huh... This is 4 days overdue. Who can take care of this?

isabelastisser commented 1 year ago

Hey @marcochavezf, any updates here?

isabelastisser commented 1 year ago

Not overdue.

marcochavezf commented 1 year ago

Not overdue.

isabelastisser commented 1 year ago

Not overdue, on hold!