[On Hold] Improve error message when a debit card is added

[marcochavezf]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

1. In NewDot sign in with an expensifail account
2. Click on the Avatar icon (Settings) -> Payments -> Add Payment method -> Debit card
3. Fill in the form and for the card number enter a valid non-debit testing card like 4111111111111111

Expected Result:

A descriptive error message should be shown.

Actual Result:

The error Auth CreateFund returned an error is shown. eg: conor@expensifail.com, getting these logs with the error showing as 400 Invalid debit card

Workaround:

We could look up the logs for the user to find the error message and communicate that to the customer to solve

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[conorpendergrast]

From this SO: https://stackoverflow.com/c/expensify/questions/14418

• [X] The "bug" is actually a bug: Yes, there's no copy for this error
• [X] The bug is not a duplicate report of an existing GH (close the GH and add any novel details to the original GH instead): Correct
• [X] The bug is reproducible, following the reproduction steps: I reproduced through conor@expensifail.com, getting these logs with the error showing as 400 Invalid debit card
• [X] If you’re unable to reproduce the bug, add the Needs reproduction label. Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.: N/A, I could reproduce
• [X] The GH template is filled out as fully as possible -- this means the GH body and title are clear (ie. could an external contributor understand it and work on it?): I added logs and error message example, and updated the workaround
• [X] The GH was created by an Expensify employee or a QA tester: Yep
• [X] If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it’s better to wait, close the GH & provide this justification: N/A, it's New Dot
• [X] If there's a link to Slack, check the discussion to see if we decided not to fix it: no Slack link, and I checked the PR that mentioned this issue
• [X] Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label: Internal, and Marco has already added that label

[melvin-bot[bot]]

@conorpendergrast, @marcochavezf Huh... This is 4 days overdue. Who can take care of this?

[conorpendergrast]

Confirming Bug0 steps for Internal issues via Slack, and then will take those here!

[conorpendergrast]

Hah, @marcochavezf has confirmed that he is working on a PR for the issue. Marco, can you link the draft PR to this issue?

[marcochavezf]

PR up to be reviewed, but on hold because of the Bancorp routing configuration.

[melvin-bot[bot]]

Triggered auto assignment to @rosegrech (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[marcochavezf]

Hi @rosegrech, just gut-checking if the copy for the error message when a user enters a non-debit card is fine (Make sure the entered debit card is a valid one):

[rosegrech]

sure thing, this is a bit smoother:

Make sure the debit card you entered is valid.

[conorpendergrast]

Do we have any idea what makes a debit card "valid" or "not valid"?

[rosegrech]

@marcochavezf ^^

[marcochavezf]

Do we have any idea what makes a debit card "valid" or "not valid"?

We only allow debit cards for this flow, and there's a possibility that the user could enter a credit or pre-paid card.

[conorpendergrast]

Ah ok, got it, so there's two possibilities:

1. They've entered an invalid debit card
2. They've entered something that isn't debit card

Make sure the debit card you entered is valid.

Seems to address 1 fine, but it's a little subtle on 2. @rosegrech what do you think on

Make sure you've entered a valid debit card.

It's a very slight rewording, but should emphasise that it has to be valid, and a debit card

[rosegrech]

Great detective work Conor!

[marcochavezf]

Cool, then Make sure you've entered a valid debit card. will be the final copy, thanks!

Additionally, I'm going to put this one on hold until we are able to communicate with Bancorp sandbox API to use test debit cards on staging/production, otherwise, Applause won't be able to test the fix when the PR is deployed.

[conorpendergrast]

I'm re-assigning to another BugZero team member in case there are any further steps, as I'm going on sabbatical in 30 minutes!

[melvin-bot[bot]]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[conorpendergrast]

@isabelastisser Nothing needed her for now, assigning you in case there's any follow-up questions from @marcochavez for anything else

[isabelastisser]

Not overdue.

[isabelastisser]

Not overdue.

[isabelastisser]

Not overdue.

[isabelastisser]

Not overdue, changing this to weekly.

[marcochavezf]

Not overdue

[marcochavezf]

Still waiting on Bancorp's response. I'm going to use this issue to post updates about it.

[isabelastisser]

Not overdue.

[isabelastisser]

Internal; not overdue.

[isabelastisser]

Internal, can I change this to Monthly? @marcochavezf

[marcochavezf]

Ah yeah, that's fine. I hope to continue with this one soon (updates here).

[marcochavezf]

No updated, focused on EYOC MVP this week

[marcochavezf]

No updated, focused on EYOC MVP this week

[marcochavezf]

No updated, focused on EYOC MVP this week

[marcochavezf]

Coming back from ECX, I will give priority to the Bancorp token for staging this week

[marcochavezf]

Still on hold

[marcochavezf]

Still on hold

[isabelastisser]

Not overdue, on hold!

[isabelastisser]

Not overdue, on hold.

[marcochavezf]

Removing the hold title since the debit test cards are not working on staging. I will work on this one in spare cycles

[slafortune]

👋 hey, quick note that we should keep all e/app GHs as daily unless they have "Hold" in the title. I'm going to flip this back to daily as I'm doing the resync and it's step in the SO process guide.

[isabelastisser]

Internal!

[isabelastisser]

Not overdue, internal!

[melvin-bot[bot]]

@marcochavezf, @isabelastisser, @rosegrech Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[marcochavezf]

Not overdue, focused on unauthenticated users in public rooms implementation for RenderATL

[melvin-bot[bot]]

@marcochavezf, @isabelastisser, @rosegrech Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@marcochavezf, @isabelastisser, @rosegrech Eep! 4 days overdue now. Issues have feelings too...

[marcochavezf]

Not overdue, focused on unauthenticated users in public rooms implementation for RenderATL

[melvin-bot[bot]]

@marcochavezf, @isabelastisser, @rosegrech Huh... This is 4 days overdue. Who can take care of this?

[isabelastisser]

Hey @marcochavezf, any updates here?

[isabelastisser]

Not overdue.

[marcochavezf]

Not overdue.

[isabelastisser]

Not overdue, on hold!