Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.86k forks source link

[On Hold] Improve error message when a debit card is added #12913

Closed marcochavezf closed 10 months ago

marcochavezf commented 1 year ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  1. In NewDot sign in with an expensifail account
  2. Click on the Avatar icon (Settings) -> Payments -> Add Payment method -> Debit card
  3. Fill in the form and for the card number enter a valid non-debit testing card like 4111111111111111

Expected Result:

A descriptive error message should be shown.

Actual Result:

The error Auth CreateFund returned an error is shown. eg: conor@expensifail.com, getting these logs with the error showing as 400 Invalid debit card

Workaround:

We could look up the logs for the user to find the error message and communicate that to the customer to solve

Platform:

Where is this issue occurring?

Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

203069941-eba69df7-7444-4d02-9a9a-c76ebc67ca43
isabelastisser commented 1 year ago

I will be OOO until July 5, so assigning another team member. SO for reference.

melvin-bot[bot] commented 1 year ago

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] commented 1 year ago

Bug0 Triage Checklist (Main S/O)

sophiepintoraetz commented 1 year ago

@isabelastisser - for next time, it would be great to include a summary of what's happened and what needs to happen while you're away!

@marcochavezf - what issue are we holding on? I see two are referenced earlier that have merged/closed?

sophiepintoraetz commented 1 year ago

I haven't had the chance to come back to it because other hight priorities and since this is feature is still behind the wallet beta. Since things have been slowed down since SHN, I have that on my list of priorities to tackle soon :)👍🏾1⠀⠀

From Marco!

sophiepintoraetz commented 1 year ago

@marcochavezf - because this is an old bug, I'm not sure we should downgrade the priority - see Puneet's post here. Let me know if I can help with prioritising!

sophiepintoraetz commented 1 year ago

@marcochavezf - let me know when you can get to an update!

marcochavezf commented 1 year ago

Created a PR to change the message, but the Bancorp sandbox token is expired again (so the change can't be tested on staging). We'd need to put this issue on hold until the token is updated.

isabelastisser commented 1 year ago

I'm back! Thanks, @sophiepintoraetz !

mountiny commented 1 year ago

Noting that it seems like the PR still did not fix the error message

melvin-bot[bot] commented 1 year ago

@marcochavezf, @isabelastisser, @rosegrech Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

mountiny commented 1 year ago

bumping here, I believe QA found this was not solve afaik @marcochavezf

isabelastisser commented 1 year ago

Not overdue!

marcochavezf commented 1 year ago

bumping here, I believe QA found this was not solve afaik @marcochavezf

Ah yes, that's because of the Bancorp token expired again, waiting for the new token here

marcochavezf commented 1 year ago

Still waiting for the new token here.

marcochavezf commented 1 year ago

Still waiting for the new token

isabelastisser commented 1 year ago

not overdue.

isabelastisser commented 1 year ago

Not overdue, on hold!

marcochavezf commented 1 year ago

Seems new sandbox token is not working locally, I will retest again soon

marcochavezf commented 1 year ago

We would need to contact Bancorp again because the token is expired too. Moving it to weekly

isabelastisser commented 1 year ago

Still on hold! @marcochavezf, did you reach out to Bancorp to follow up on the token issue?

isabelastisser commented 1 year ago

Still on hold.

isabelastisser commented 1 year ago

Internal, still on hold.

isabelastisser commented 1 year ago

@marcochavezf any progress here? Thanks!

marcochavezf commented 1 year ago

We're depending on a new sandbox token but we're focused on waves

isabelastisser commented 1 year ago

Not overdue, on hold.

marcochavezf commented 1 year ago

This GH also depends on a new sandbox token, more details here

isabelastisser commented 1 year ago

on hold!

isabelastisser commented 1 year ago

Still on hold!

isabelastisser commented 11 months ago

Moving to monthly, still on hold.

isabelastisser commented 10 months ago

@marcochavezf still on hold? Should we close this, given our new priorities?

isabelastisser commented 10 months ago

Bump @marcochavezf on my question above. Thanks!

marcochavezf commented 10 months ago

Yeah, sounds good, let's close this one