[On Hold] Improve error message when a debit card is added

[marcochavezf]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

1. In NewDot sign in with an expensifail account
2. Click on the Avatar icon (Settings) -> Payments -> Add Payment method -> Debit card
3. Fill in the form and for the card number enter a valid non-debit testing card like 4111111111111111

Expected Result:

A descriptive error message should be shown.

Actual Result:

The error Auth CreateFund returned an error is shown. eg: conor@expensifail.com, getting these logs with the error showing as 400 Invalid debit card

Workaround:

We could look up the logs for the user to find the error message and communicate that to the customer to solve

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

[isabelastisser]

I will be OOO until July 5, so assigning another team member. SO for reference.

[melvin-bot[bot]]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sophiepintoraetz]

@isabelastisser - for next time, it would be great to include a summary of what's happened and what needs to happen while you're away!

@marcochavezf - what issue are we holding on? I see two are referenced earlier that have merged/closed?

[sophiepintoraetz]

I haven't had the chance to come back to it because other hight priorities and since this is feature is still behind the wallet beta. Since things have been slowed down since SHN, I have that on my list of priorities to tackle soon :)👍🏾1⠀⠀

From Marco!

[sophiepintoraetz]

@marcochavezf - because this is an old bug, I'm not sure we should downgrade the priority - see Puneet's post here. Let me know if I can help with prioritising!

[sophiepintoraetz]

@marcochavezf - let me know when you can get to an update!

[marcochavezf]

Created a PR to change the message, but the Bancorp sandbox token is expired again (so the change can't be tested on staging). We'd need to put this issue on hold until the token is updated.

[isabelastisser]

I'm back! Thanks, @sophiepintoraetz !

[mountiny]

Noting that it seems like the PR still did not fix the error message

[melvin-bot[bot]]

@marcochavezf, @isabelastisser, @rosegrech Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

bumping here, I believe QA found this was not solve afaik @marcochavezf

[isabelastisser]

Not overdue!

[marcochavezf]

bumping here, I believe QA found this was not solve afaik @marcochavezf

Ah yes, that's because of the Bancorp token expired again, waiting for the new token here

[marcochavezf]

Still waiting for the new token here.

[marcochavezf]

Still waiting for the new token

[isabelastisser]

not overdue.

[isabelastisser]

Not overdue, on hold!

[marcochavezf]

Seems new sandbox token is not working locally, I will retest again soon

[marcochavezf]

We would need to contact Bancorp again because the token is expired too. Moving it to weekly

[isabelastisser]

Still on hold! @marcochavezf, did you reach out to Bancorp to follow up on the token issue?

[isabelastisser]

Still on hold.

[isabelastisser]

Internal, still on hold.

[isabelastisser]

@marcochavezf any progress here? Thanks!

[marcochavezf]

We're depending on a new sandbox token but we're focused on waves

[isabelastisser]

Not overdue, on hold.

[marcochavezf]

This GH also depends on a new sandbox token, more details here

[isabelastisser]

on hold!

[isabelastisser]

Still on hold!

[isabelastisser]

Moving to monthly, still on hold.

[isabelastisser]

@marcochavezf still on hold? Should we close this, given our new priorities?

[isabelastisser]

Bump @marcochavezf on my question above. Thanks!

[marcochavezf]

Yeah, sounds good, let's close this one