[HOLD for payment 2024-02-20] [$1000] [Polish] Add limit on length of task names, room names, etc.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any Expensifail account
3. Go to FAB -> Assign task
4. Start typing the title and note that there is no symbol limit

Expected Result:

After discussion in Slack, we want to make the following field limit updates:

Titles (100 characters):

• Workspace name
• Task name
• Room name

Supporting messages (500 characters):

• Request description
• Room welcome message
• Task description

Actual Result:

There is no limit on the length of the title. Same behavior for Description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android / native
• [x] Android / Chrome
• [x] iOS / native
• [x] iOS / Safari
• [x] MacOS / Chrome / Safari
• [x] MacOS / Desktop

Version Number: 1.3.12.0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/05b9957a-b07e-4625-9e73-3b720dea6b93

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018a42c5fcacc50150
• Upwork Job ID: 1686014963280871424
• Last Price Increase: 2023-07-31
• Automatic offers:
• dhairyasenjaliya | Contributor | 26010517

[melvin-bot[bot]]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[joekaufmanexpensify]

My initial thought is this is not a bug, and should be a new feature issue. Confirming here.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign Task field does not have limit on length

What is the root cause of that problem?

We don't have maxLength defined for the input here.

What changes do you think we should make in order to solve the problem?

We should add a maxLength attribute with the required length that we want to restrict the users to here.

What alternative solutions did you explore? (Optional)

None

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Assign Task - There is no limit on the length of the title 

What is the root cause of that problem?

• The root cause is we have not add any maxLength or any validation to check before form submission

What changes do you think we should make in order to solve the problem?

• The problem not only exists on New task page we need to modify this all files NewTaskDetailsPage.js , NewTaskTitlePage.js, NewTaskTitlePage.js , TaskTitlePage.js , NewTaskDescriptionPage.js , TaskDescriptionPage.js

• To fix the problem we have 2 ways to solve 


  solution 1

• We can add maxLength (need to define limit) to both the field title and description which are inputID="taskTitle” and inputID="description" on all the above mentioned pages that are affected by infinite character limit

  solution 2

• Since we are using <Form> on validate() function we can just check length of the both field and based on that we can direct display error

  What alternative solutions did you explore? (Optional)

• None

[joekaufmanexpensify]

Still getting confirmation that this should be a new feature issue, and not a bug.

[joekaufmanexpensify]

Okay, we discussed this in Slack here, and I confirmed this is not a bug. We just didn't build this.

While it prob makes sense to add a limit at some point, we decided we don't need to prioritize this and it can be polish. Particularly because:

• We also don't have a limit for room names, and this has caused no issues so far.
• We don't allow multiple characters by holding down a key in the app. So if someone wants to make a task that's 100 characters long, they need to type 100 keys. It doesn't feel super realistic that a user would intentionally make a room or task name that's longer than any limit we decided to set.

When we do ultimately decide to do this, we'll want to consider all of the areas that don't have a limit, like task name, room name, etc. and add a limit to all of them.

[melvin-bot[bot]]

Current assignee @joekaufmanexpensify is eligible for the NewFeature assigner, not assigning anyone new.

[joekaufmanexpensify]

Next steps here are to:

1. identify anywhere in the app that needs a name limit.
2. Figure out what we think that limit should be.
3. Implement the limit in all of those places.

This is a minor polish issue, so will get to it in the next few weeks.

[dhairyasenjaliya]

@joekaufmanexpensify we can add this one here also https://github.com/Expensify/App/issues/18891

[joekaufmanexpensify]

Sounds good!

[joekaufmanexpensify]

Will prioritize this soon.

[joekaufmanexpensify]

OOO next week, but then will pick this back up.

[dhairyasenjaliya]

This can be added here https://github.com/Expensify/App/issues/19821#issue-comment-box

[dhairyasenjaliya]

another potential GH to add it here https://github.com/Expensify/App/issues/20137 @joekaufmanexpensify

[joekaufmanexpensify]

Was OOO last week, going to look into this soon

[joekaufmanexpensify]

Going to focus on this this week!

[joekaufmanexpensify]

Started a discussion with proposed limits here.

[joekaufmanexpensify]

Discussion is still ongoing!

[dangrous]

Do we have a plan for workspace name limits too? I saw https://expensify.slack.com/archives/C01GTK53T8Q/p1686952259007779?thread_ts=1686863510.616919&cid=C01GTK53T8Q but wasn't sure if workspace names would be included in one of those categories as well. Asking due to https://github.com/Expensify/App/issues/19359 - thanks!

[joekaufmanexpensify]

Yep, we're considering workspace name limits

[joekaufmanexpensify]

Did some research on why we selected existing limits last week. Going to bring to slack today!

[joekaufmanexpensify]

Ran out of time for this last week. But going to post an update today.

[dhairyasenjaliya]

we can probably add this one https://github.com/Expensify/App/issues/22201

[joekaufmanexpensify]

I posted an update on this in the slack discussion today!

[joekaufmanexpensify]

Still discussing in Slack thread after last week's update!

[joekaufmanexpensify]

We agreed on limit thresholds in Slack! Next step is for me to identify where we're going to change the limits this week

[joekaufmanexpensify]

Posting an update to the slack thread today!

[joekaufmanexpensify]

Update here

[joekaufmanexpensify]

Updated the new expected result in OP based on where the slack discussion landed. We're not all set to work on this!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~018a42c5fcacc50150

[melvin-bot[bot]]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[joekaufmanexpensify]

cc @allroundexperts @dhairyasenjaliya if you want to update your previous proposals to match the next expected behavior here, we're now all set to proceed!

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Add limit on length of task names, room names, etc. 

What is the root cause of that problem?

• We have decide new limit for above fields we just need to set in the app

What changes do you think we should make in order to solve the problem?

• As per the latest updated we need to change below field

Titles (100 characters):

• Workspace name

  • On CONST.js we need to modify WORKSPACE_NAME_CHARACTER_LIMIT from 80 to 100

• Task name

  • We should add a new const as TASK_NAME_LIMIT and set to 100
  • We need to add on maxLength prop to <TextInput> inside 3 pages NewTaskDetailsPage.js , NewTaskTitlePage.js, TaskTitlePage.js

• Room name

  • On CONST.js we need to modify MAX_ROOM_NAME_LENGTH from 79 to 100

Supporting message (500 characters):

• Request description

  • We should add a new const as MONEY_REQUEST_DESCRIPTION_LIMIT and set to 500
  • We need to add on maxLength prop to <TextInput> inside 2 pages MoneyRequestDescriptionPage.js and EditRequestDescriptionPage.js

• Room welcome message

  • We should add a new const as WELCOME_MESSAGE_LIMIT and set to 500
  • We need to add this new limit onto ReportWelcomeMessagePage.js here we are using wrong limit as MAX_COMMENT_LENGTH
  • (Optionally) We can add this limit to WorkspaceInviteMessagePage.js here as well to be consistency

• Task description

  • We should add a new const as TASK_NAME_LIMIT and set to 100
  • We need to add on maxLength prop to <TextInput> inside 3 pages NewTaskDescriptionPagejs , NewTaskDetailsPage.js, TaskDescriptionPage.js

  What alternative solutions did you explore? (Optional)

• Since we are using <Form> on validate() function we can just check length of the both field and based on that we can direct display error based on above lengths

At the time of adding proposal, non of the proposal includes a new requirement

[Santhosh-Sellavel]

Left a comment here for volunteers to take over

[mananjadhav]

Taking this over.

[joekaufmanexpensify]

Sounds great, thanks!

[melvin-bot[bot]]

📣 @mananjadhav Please request via NewDot manual requests for the Contributor role ($1000)

[mananjadhav]

@dhairyasenjaliya's proposal here. I was wondering if we should just have two constants TITLE_MAX_LENGTH and SUPPORTING_TEXT_MAX_LENGTH.

Will also take feedback form @youssef-lr on this one.

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mananjadhav]

Quick bump on this one @youssef-lr.

[dhairyasenjaliya]

@mananjadhav @youssef-lr Also for WorkspaceName and RoomName we need to set the character limit to 100 as well currently both have 80 from the backend so this required backend changes as well

[joekaufmanexpensify]

Pending review of proposal by @youssef-lr

[joekaufmanexpensify]

Bumped Youssef 1:1.

[joekaufmanexpensify]

Youssef's been OOO, but is going to review this one soon!

[joekaufmanexpensify]

Still pending input from @youssef-lr

[melvin-bot[bot]]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot[bot]]

📣 @dhairyasenjaliya 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[youssef-lr]

LGTM @mananjadhav, we can decide on the details in the PR I think.