eh2077
commented
1 year ago Proposal
Please re-state the problem that we are trying to solve in this issue.
App throws 'No content to add' error if we send empty alias for email.
What is the root cause of that problem?
The root cause of this issue is that below markdown
[](test@gmail.com)is translated into html
<a href="mailto:test@gmail.com"></a>by applying email rule
{
name: 'email',
process: (textToProcess, replacement) => {
const regex = new RegExp(
`\\[([^[\\]]*)]\\(${CONST.REG_EXP.MARKDOWN_EMAIL}\\)`, 'gim'
);
return this.modifyTextForEmailLinks(regex, textToProcess, replacement);
},
replacement: (match, g1, g2) => `<a href="mailto:${g2}">${g1.trim()}</a>`,
}The capturing group g1, ([^[\\]]*) , is possible to be empty string and, in the replacement method, we didn't check if g1.trim()is empty or not. So, we get anchor tag with empty text by apply the email rule.
The backend returns an error when we try to save html <a href="mailto:test@gmail.com"></a> to the backend. The error returned by backend is
I think the error from backend makes sense because the backend needs to convert html
<a href="mailto:test@gmail.com"></a>to text(aka message[0].text) which shouldn't be empty.
So the root cause of this issue is that email rule doesn't avoid creating anchor tag with empty text.
What changes do you think we should make in order to solve the problem?
To fix this issue, we can skip creating anchor tag with empty text.
To achieve this, we can change the replacement method of email rule from
replacement: (match, g1, g2) => `<a href="mailto:${g2}">${g1.trim()}</a>`,to
// skip rendering if g1.trim() is empty
replacement: (match, g1, g2) => (!g1.trim() ? match : `<a href="mailto:${g2}">${g1.trim()}</a>`),Below is the demo video of the solution
https://github.com/Expensify/App/assets/117511920/4fc47889-2aa8-4e10-93eb-4d9eb94d037a
What alternative solutions did you explore? (Optional)
We can also add a negative lookahead group at the beginning of the regex to skip matching email markdown syntax starts with \[\s*\].
To achieve it, we can change the regex
`\\[([^[\\]]*)]\\(${CONST.REG_EXP.MARKDOWN_EMAIL}\\)`, 'gim'to
`(?!\\[\\s*\\])\\[([^[\\]]*)]\\(${CONST.REG_EXP.MARKDOWN_EMAIL}\\)`, 'gim'The negative lookahead group (?!\[\s*\]) will be able to skip matching linkText includes only whitespaces(including linebreaks because the regex has multiple line flag m). See below demo video including more test cases.
https://github.com/Expensify/App/assets/117511920/d20de407-1cc7-4990-95e8-fa653b25b9c2
melvin-bot[bot]
laurenreidexpensify
parasharrajat
YacineF0001
Format:
Gonals
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
[](google.com)[](test@test.com)Expected Result:
App should handle empty alias for email in similar way like it does for link
Actual Result:
App throws 'No content to add' error for email with empty alias
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.30.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/3efe4b24-22e0-47e5-9758-5bae899a4dac
https://github.com/Expensify/App/assets/93399543/b68bed52-6612-4012-9223-1ffaf656b18d
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686755882619169
View all open jobs on GitHub
Upwork Automation - Do Not Edit