[$1000] Web - Sidebar re-arrange on moving to report from split group

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Split a bill
2. Add 3 users
3. Create the bill
4. Observe the sidebar
5. Click on the bill in the split group
6. Click on any profile in split with section in the sidebar
7. Select message [name]
8. Observer the pattern
9. You can repeat from step 5 for other users

Expected Result:

When clicking on any report, it's position in LHN should not change until data has been added to the compose box.

Actual Result:

The reports in LHN changes it's indexes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] Android / Chrome
• [ ] iOS / native
• [ ] iOS / Safari
• [x] MacOS / Chrome / Safari
• [ ] MacOS / Desktop

Version Number: 1.3.47.3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/88d3a3e0-2931-44e7-b395-5e6f521ec8c1

https://github.com/Expensify/App/assets/93399543/eabdaf38-c31a-4015-be63-8f1f3b61be50

Expensify/Expensify Issue URL: Issue reported by: @krishna2323 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690663983822269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01005e4b179e77b28f
• Upwork Job ID: 1694361641774350336
• Last Price Increase: 2023-08-23

[melvin-bot[bot]]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Problem was that when opening a chat from a slit bill's details the chat changes its order in the LHN list.

What is the root cause of that problem?

1. Let say we have A (Logged in user), B and C users in a group.
2. Now we created a split bill with those three users, the lastVisibleActionCreated property of group's report is updated but not of the individual user's report of B and C.
3. Now we open the B's individual report from particpants list and after that the lastVisibleActionCreated property of B's report is updated.
4. Same for C's Report.

What changes do you think we should make in order to solve the problem?

• We need to update lastVisibleActionCreated of all the individuals reports also.
• Which i think is a BE change.

What alternative solutions did you explore? (Optional)

• N/A

[melvin-bot[bot]]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot[bot]]

@mallenexpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[mallenexpensify]

Was off for few days and swamped with a project deadline, will get to this soon

[melvin-bot[bot]]

@mallenexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot[bot]]

@mallenexpensify 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot[bot]]

@mallenexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot[bot]]

@mallenexpensify 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot[bot]]

@mallenexpensify 12 days overdue now... This issue's end is nigh!

[mallenexpensify]

The reports in LHN should not change its position on moving to someone's profile. @Krishna2323 efore I updated the expected behaviour to be more broad.
When clicking on any report, it's position in LHN should not change until data has been added to the compose box.

1. I wonder why this is specifically happening with reports from split bills
2. I wonder if it's happening anywhere else.

[melvin-bot[bot]]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01005e4b179e77b28f

[melvin-bot[bot]]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[mallenexpensify]

Removed/readded the Bug label to hopefully reset the timer since I didn't address this for weeks and I don't think it needs to be/go internal

[melvin-bot[bot]]

@mallenexpensify @abdulrahuman5196 this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

[abdulrahuman5196]

This only became external couple of days back. This shouldn't be internal ideally. But anyways will review the only proposal we have and update.

[melvin-bot[bot]]

@mallenexpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

@abdulrahuman5196 , please review @jeet-dhandha 's proposal when you have a minute https://github.com/Expensify/App/issues/23905#issuecomment-1657598424

[melvin-bot[bot]]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

@MitchExpensify I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx

[MitchExpensify]

Can do @mallenexpensify

[mallenexpensify]

@abdulrahuman5196 , please review @jeet-dhandha 's proposal when you have a minute https://github.com/Expensify/App/issues/23905#issuecomment-1657598424

Thanks @MitchExpensify for 👀

[abdulrahuman5196]

Hi, @jeet-dhandha.

I am not able to understand both the root cause and the solution from proposal. Could you provide more detailed information on the same?

[jeet-dhandha]

I will get back by tomorrow. As i also forgot what the solution was as its been more than 1.5 month.

[melvin-bot[bot]]

@mallenexpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[abdulrahuman5196]

We are not having any more proposals to review. @jeet-dhandha needs to update proposal

[jeet-dhandha]

Proposal Updated https://github.com/Expensify/App/issues/23905#issuecomment-1657598424. Sorry for delay.

[mallenexpensify]

Thanks. @abdulrahuman5196 , can you review @jeet-dhandha 's updated proposal above?

[melvin-bot[bot]]

@mallenexpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[mallenexpensify]

Reassigning C+ due to inactivity @parasharrajat please review https://github.com/Expensify/App/issues/23905#issuecomment-1657598424

[parasharrajat]

Reviewing in 2 hours.

[parasharrajat]

So I checked and @jeet-dhandha's proposal looks correct. We will have to make changes from both the front end and back end. It might be possible that we don't have to change the backend.

But I am not an expert on this subject either. It would be great to have it reviewed by an internal team member.

I am approving to assign an Engineer and then we can discuss the proposal further. @jeet-dhandha Do you mind adding more detail to the solution to explain how will achieve it?

I would suggest that you repost a fresh proposal so that we don't have to scroll all the way back.

:ribbon: :eyes: :ribbon: C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jeet-dhandha]

I will need some time to create a full proposal as all the time related implementation is a bit hard to understand so trying to figure out the best way to handle this. 👍

[jeet-dhandha]

• I have user 201 (Logged In User), 202 and 203.
• Now i created group with 202 and 203.
• Now i added a split bill.

How should all the chats be ordered after the split bill is created and rest IOU Reports or Chat Reports are created or updated?

[pecanoro]

Hmmm I think this might be on purpose since they get ordered from last seen, but I will check.

[jeet-dhandha]

https://github.com/Expensify/App/assets/78416198/db43fcdc-889e-4ee8-99ff-584d7a98609e

Also the timestamp is updated from backend instead of using the sent lastVisibleActionCreated.

SENT - ONYX Data

"lastVisibleActionCreated": "2023-09-27 03:24:13.036", => GROUP (report_6606139833156882)
"lastVisibleActionCreated": "2023-09-27 03:24:13.038", => CHAT (report_7926651244820297)
"lastVisibleActionCreated": "2023-09-27 03:24:13.037", => IOU (report_5105409794206698)
"lastVisibleActionCreated": "2023-09-27 03:24:13.041", => CHAT (report_7690011831439707)
"lastVisibleActionCreated": "2023-09-27 03:24:13.040", => IOU (report_1974921079093219)

RECEIVED - ONYX Data

"lastVisibleActionCreated": "2023-09-27 03:24:13.345", => IOU (report_5105409794206698) 
"lastVisibleActionCreated": "2023-09-27 03:24:13.347", => IOU (report_1974921079093219)
"lastVisibleActionCreated": "2023-09-27 03:24:13.343", => GROUP (report_6606139833156882)

[pecanoro]

I don't see any bugs here, I think this is working just fine. @mallenexpensify Do you have anything against closing this one?

[jeet-dhandha]

@pecanoro The above video is after the fix i added for incremental “lastVisibleActionCreated”.

[jeet-dhandha]

As we need incremental timestamp and also we need to stop updating “lastReadTime” to current time as its making Reports marked as read instead of showing in “bold”

[pecanoro]

As we need incremental timestamp and also we need to stop updating “lastReadTime” to current time as its making Reports marked as read instead of showing in “bold”

I see them bold unless I open them.

[jeet-dhandha]

Please test same thing on “main” the IOU reports are not highlighted (gets bold).

• Also currently on main, IOU timestamp and Chat have same timestamp.