[$500] Log in - New accounts on domain control that have had a bill split with them cannot login on a domain controlled account.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.88.1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @kevinksullivan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697856462347089

Action Performed:

1. Split bill with new user that is using an email on a domain controlled account
2. Go try to sign up with that user you split a bill with in 1

Expected Result:

User can sign up and get a magic code

Actual Result:

Error message, blocked from signing in

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

 

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01237b5b3352b4c2e4
• Upwork Job ID: 1715751193396441088
• Last Price Increase: 2023-12-16

[melvin-bot[bot]]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01237b5b3352b4c2e4

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[debragail]

Proposal

Please re-state the problem that we are trying to solve in this issue.

New users that have had a bill split with them cannot login to a domain controlled account. This occurs on Get Started on the homepage on staging.

What changes do you think we should make in order to solve the problem?

Make sure the bill split account are assigned a account id that belongs to the domain controlled account if the domains are the same. It seems the account details are not able to be retrieved.

https://github.com/Expensify/App/blob/fcee2073f096ad60dd9f30c536342de7d3893282/src/pages/ValidateLoginPage/index.js#L46

What alternative solutions did you explore? (Optional)

Change error mess

[isabelastisser]

Hey @0xmiroslav can you please review the proposal above? Thanks!

[isabelastisser]

@0xmiroslav can you please review the proposal above?

[debragail]

Please let me know if you accept since this is overdue.

[0xmiros]

will provide feedback on Monday

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[isabelastisser]

@0xmiroslav, any updates?

[0xmiros]

@debragail your proposal is missing root cause

[0xmiros]

@isabelastisser we're still awaiting proposals here

[isabelastisser]

Waiting for proposals.

[melvin-bot[bot]]

@isabelastisser @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[debragail]

I am working on a new proposal.

[debragail]

I need help recreating the issue:

https://expensify.slack.com/archives/C01GTK53T8Q/p1699217765377179

[isabelastisser]

Hey @0xmiroslav can you please follow up on the commend above? Thanks!

[0xmiros]

I need help recreating the issue:

https://expensify.slack.com/archives/C01GTK53T8Q/p1699217765377179

I see it's resolved on slack thread. Still waiting proposals

[isabelastisser]

Waiting for proposals!

[melvin-bot[bot]]

@isabelastisser @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@isabelastisser, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@isabelastisser, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[isabelastisser]

Still waiting for proposals.

[isabelastisser]

Still waiting for proposals.

FYI I'm OOO until Nov 27.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@isabelastisser, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@isabelastisser, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@isabelastisser, @0xmiroslav 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[0xmiros]

No satisfactory proposals yet

[isabelastisser]

Still waiting for proposals!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[isabelastisser]

Still waiting for proposals!

[isabelastisser]

Still waiting for proposals!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@isabelastisser, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[isabelastisser]

Discussion here.

[isabelastisser]

@0xmiroslav @debragail, can you please clarify what scenarios the bug can occur in? Is this bug isolated to splitting a bill with someone?

[isabelastisser]

Bump @0xmiroslav @debragail on my question above. thanks!

[isabelastisser]

@0xmiroslav @debragail, can you please follow up on my questions above?

Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Tony-MK]

Hey, @isabelastisser and @0xmiroslav, I wanted to provide my investigation findings. I hope it helps.

This issue requires a backend fix and possibly some frontend changes to match because the user of the Gmail-controlled account can solve it by inviting the user of the new domain-controlled account to the domain on Old Dot.

The problem might be the server is incorrectly authenticating optimistically created domain-controlled accounts.

Instead of splitting a bill, I started a chat and got the same error message from the server.

Furthermore, I got the same error message when using a Gmail-controlled account to a domain-controlled employee account (like the description) and a Gmail-controlled admin account to a domain-controlled employee account.

Could you verify that my analysis is correct? Thanks 😄

Error message from server

[isabelastisser]

Thanks for the details @Tony-MK! @0xmiroslav, can you please review and follow up on the explanation above?

[0xmiros]

Agree this requires backend fix. 🎀 👀 🎀

[melvin-bot[bot]]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

[isabelastisser]

Do we need an Expensify engineer to work on this @0xmiroslav ?