Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

[$500] Log in - New accounts on domain control that have had a bill split with them cannot login on a domain controlled account. #30121

Closed kbecciv closed 8 months ago

kbecciv commented 11 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.88.1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @kevinksullivan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697856462347089

Action Performed:

  1. Split bill with new user that is using an email on a domain controlled account
  2. Go try to sign up with that user you split a bill with in 1

Expected Result:

User can sign up and get a magic code

Actual Result:

Error message, blocked from signing in

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari ![image (15)](https://github.com/Expensify/App/assets/93399543/2ab12dce-bb27-4fa8-a2bb-0480f325aff6) ![image (14)](https://github.com/Expensify/App/assets/93399543/1a50d408-f684-455b-bcdd-613a2ce51cad)
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01237b5b3352b4c2e4
  • Upwork Job ID: 1715751193396441088
  • Last Price Increase: 2023-12-16
0xmiros commented 9 months ago

Do we need an Expensify engineer to work on this @0xmiroslav ?

yes, at least on backend part. Hope @blimpich would help with this issue 🙏

debragail commented 9 months ago

@isabelastisser should I still work on the issue?

blimpich commented 9 months ago

yes, at least on backend part. Hope @blimpich would help with this issue 🙏

Acknowledging this. I think this is worth working on but I am currently prioritizing other issues. Thank you @0xmiroslav for summarizing the state of this issue at the moment. I don't know when I'll have time to work on this, but hopefully sometime next week.

isabelastisser commented 9 months ago

This will be reviewed next week.

blimpich commented 9 months ago

Demoting to weekly until I know that I can work on this daily.

mvtglobally commented 9 months ago

Issue not reproducible during KI retests. (First week)

isabelastisser commented 9 months ago

Not overdue.

mvtglobally commented 8 months ago

Issue not reproducible during KI retests. (Second week)

blimpich commented 8 months ago

Not overdue. Not reproducing so might be a non-issue. Will let this sit for now.

isabelastisser commented 8 months ago

@blimpich I'll close this since it cannot be reproduced.