Closed kbecciv closed 8 months ago
Triggered auto assignment to @isabelastisser (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Job added to Upwork: https://www.upwork.com/jobs/~01237b5b3352b4c2e4
Platforms
in OP are β
)Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External
)
New users that have had a bill split with them cannot login to a domain controlled account. This occurs on Get Started on the homepage on staging.
Make sure the bill split account are assigned a account id that belongs to the domain controlled account if the domains are the same. It seems the account details are not able to be retrieved.
Change error mess
Hey @0xmiroslav can you please review the proposal above? Thanks!
@0xmiroslav can you please review the proposal above?
Please let me know if you accept since this is overdue.
will provide feedback on Monday
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
@0xmiroslav, any updates?
@debragail your proposal is missing root cause
@isabelastisser we're still awaiting proposals here
Waiting for proposals.
@isabelastisser @0xmiroslav this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
I am working on a new proposal.
I need help recreating the issue:
https://expensify.slack.com/archives/C01GTK53T8Q/p1699217765377179
Hey @0xmiroslav can you please follow up on the commend above? Thanks!
I need help recreating the issue:
https://expensify.slack.com/archives/C01GTK53T8Q/p1699217765377179
I see it's resolved on slack thread. Still waiting proposals
Waiting for proposals!
@isabelastisser @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
@isabelastisser, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@isabelastisser, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!
Still waiting for proposals.
Still waiting for proposals.
FYI I'm OOO until Nov 27.
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
@isabelastisser, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!
@isabelastisser, @0xmiroslav Eep! 4 days overdue now. Issues have feelings too...
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
@isabelastisser, @0xmiroslav 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
No satisfactory proposals yet
Still waiting for proposals!
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
Still waiting for proposals!
Still waiting for proposals!
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
@isabelastisser, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Discussion here.
@0xmiroslav @debragail, can you please clarify what scenarios the bug can occur in? Is this bug isolated to splitting a bill with someone?
Bump @0xmiroslav @debragail on my question above. thanks!
@0xmiroslav @debragail, can you please follow up on my questions above?
Thanks!
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
Hey, @isabelastisser and @0xmiroslav, I wanted to provide my investigation findings. I hope it helps.
This issue requires a backend fix and possibly some frontend changes to match because the user of the Gmail-controlled account can solve it by inviting the user of the new domain-controlled account to the domain on Old Dot.
The problem might be the server is incorrectly authenticating optimistically
created domain-controlled accounts.
Instead of splitting a bill, I started a chat and got the same error message from the server.
Furthermore, I got the same error message when using a Gmail-controlled account to a domain-controlled employee account (like the description) and a Gmail-controlled admin account to a domain-controlled employee account.
Could you verify that my analysis is correct? Thanks π
Thanks for the details @Tony-MK! @0xmiroslav, can you please review and follow up on the explanation above?
Agree this requires backend fix. π π π
Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.
Do we need an Expensify engineer to work on this @0xmiroslav ?
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.88.1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @kevinksullivan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697856462347089
Action Performed:
Expected Result:
User can sign up and get a magic code
Actual Result:
Error message, blocked from signing in
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
![image (15)](https://github.com/Expensify/App/assets/93399543/2ab12dce-bb27-4fa8-a2bb-0480f325aff6) ![image (14)](https://github.com/Expensify/App/assets/93399543/1a50d408-f684-455b-bcdd-613a2ce51cad)MacOS: Desktop
View all open jobs on GitHub
Upwork Automation - Do Not Edit