Open kavimuru opened 7 months ago
Triggered auto assignment to @zanyrenney (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
ONYXKEYS.COLLECTION.POLICY_RECENTLY_USED_CURRENCIES
, need to be stored in BE as wellONYXKEYS.COLLECTION.POLICY_RECENTLY_USED_CURRENCIES
as we did with categories:
https://github.com/Expensify/App/blob/f3111a472b72c475a89703fce4cdde4fdd75d42f/src/libs/actions/IOU.js#L410-L416Yep, this looks like it should be external to me. adding the label though!
Job added to Upwork: https://www.upwork.com/jobs/~01964421591b4aea1b
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External
)
@getusha what do you think of the proposal from @DylanDylann ?
@DylanDylann is it possible to implement this future without having to create a new Onyx key?
@getusha I think it needs to be stored in BE as well so cannot implement without creating new Onyxkey.
Probably adding a new key to the currency object will be ideal? Pulling internal engineer to take a look at this π π π
Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@thienlnam What do you think about this comment?
Yeah, if we're adding recently selected for currency selection we'll likely want another onyx key for consistency with the other recently used items. There's also a few BE changes we'll also need to make to support this update.
Though instead of keying this by policy, we should probably just create a general recentlyUsedCurrencies field for the account - currency selection is typically user-centric and independent of individual policy constraints
@zanyrenney Could you see which wave this would fit in to see if we should work on this now or not?
sure thing! i think this should be in wave6 but I will drop it in for greg to make a call.
We can proceed with @DylanDylann's proposal, i think we should first complete the backend changes first @thienlnam?
Yup, we'll need to do that first - let me see if someone else is interested is taking these changes on
find anyone interested in taking on the changes @thienlnam
?
You're looking at him! π I'll get the internal changes up later this week
woo thanks @thienlnam please update the issue with your progress π
Got started on a draft PR - looks like we haven't been storing this anywhere since we always rely on the user's current location
Currently going through all the places that a currency could be used - scan / create / update and then adding tests
Nice, thanks for the update @thienlnam can you let me know how your progress is going now?
Bump @thienlnam how you going here?
Haven't made any new updates here - been working on Track Expense. Will likely get back to this next week
waiting on @thienlnam - changing to make him owner until its able to be prioritised as there is nothing I or @getusha can do for now until then.
@thienlnam, @zanyrenney, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!
@thienlnam is OOO, will get back to this when he returns.
Not sure where you got that from @getusha - i checked internally @thienlnam isn't OOO yesterday π
@thienlnam can you please update this issue with your work / what the latest update is.
I was OOO on Monday for President's day. I'm back now, I've been catching up and focused on Track which is blocking some other wave 6 critical issues so I haven't made any new progress.
I don't think this is that urgent as a new feature, so I'm going to move this to a weekly - though feel free to find someone to take it over if you would like it done sooner
Not sure where you got that from @getusha
@zanyrenney noticed it from slack profile :)
oh weird haha i didn't see that in our internal update for OOO, but all good, thanks!
BE PR is merged so we're saving all the used currencies by policy, but we're not sending any pusher updates - that's currently held on Ioni's project of Standardize how we save NVPs in onyx
.
Going to update the issue title to reflect that
On HOLD.
Polish / waiting for BE changes.
hey @thienlnam when do you think we'll be prioritising this one?
@iwiznia Seems like we're pretty close to sending out all account updates, when do you think that will be live?
close to sending out all account updates
I don't know what you mean
For this project https://github.com/Expensify/Expensify/issues/364560
Any update further here please @thienlnam
Ah yeah, so the BE changes are done - but we didn't send any pusher updates in anticipation for this change which will send account NVPs automatically.
Once that is done, we can turn this external to have someone add the recents key
That project is done, I even sent the project done email today (removed the hold)
Oh nice! Okay in that case I just need to pass the onyx key to the client (doing that here), and then a contributor can start on the FE changes
@thienlnam Could you check this comment? I can handle this one
bump @thienlnam please can you respond to the comment above?
Yup, once the Auth PR is merged you can go ahead and handle the FE changes.
The onyx key will be under nvp_recentlyUsedCurrencies
π£ @getusha π An offer has been automatically sent to your Upwork account for the Reviewer role π Thanks for contributing to the Expensify app!
π£ @DylanDylann π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
@DylanDylann You should be ready to start on this now - the holding code is deployed
The currencies are keyed by policyID
nvp_recentlyUsedCurrencies: {
01DC7E46150451C4: ['USD', 'CAD'],
0426477218E500C1: ['USD', 'CAD'],
1CAFAAA6EAD09539: ['USD', 'CAD'],
}
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.29-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705664342497829
Action Performed:
Go to change the currency on a an expense
Expected Result:
We have a list selection pattern where the current selected item is at the top, and we have a section for recents underneath that. I would expect currency selection to work the same.
Actual Result:
There is no section for recents, and your currently selected item is not at the top.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence![Snip - (2) New Expensify - Google Chrome](https://github.com/Expensify/App/assets/43996225/e67d38df-7352-4f02-ab96-ee26ba685f87)
View all open jobs on GitHub
Upwork Automation - Do Not Edit