search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.18k stars 2.66k forks source link

[$500] [MEDIUM] [Feature Request] Currency selection screen should have "Recents" at top #34874

Open kavimuru opened 6 months ago

kavimuru commented 6 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.29-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705664342497829

Action Performed:

Go to change the currency on a an expense

Expected Result:

We have a list selection pattern where the current selected item is at the top, and we have a section for recents underneath that. I would expect currency selection to work the same.

Actual Result:

There is no section for recents, and your currently selected item is not at the top.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence Snip - (2) New Expensify - Google Chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01964421591b4aea1b
  • Upwork Job ID: 1750537225734946816
  • Last Price Increase: 2024-01-25
  • Automatic offers:
    • getusha | Reviewer | 0
    • DylanDylann | Contributor | 0
DylanDylann commented 2 months ago

@thienlnam I am working on this issue but I cannot find the nvp_recentlyUsedCurrencies. Can you help check whether the BE changes are deployed?

thienlnam commented 2 months ago

You might need to create / edit some transactions to populate it so that it is returned - let me know if that works

DylanDylann commented 2 months ago

Yes. I tried to create a transaction, but there is no nvp_recentlyUsedCurrencies data returned image

thienlnam commented 2 months ago

Ah okay, it seems like there are still a few locations where the currency needs to be updated.

Right now this works if you go into Expensify classic, create a transaction, add it to a report on a workspace, and then change the currency.

That will get the NVP to show up in Onyx. Anyways, the structure on the onyx key won't change so you should be able to start with that and use Expensify classic to load the initial test data

DylanDylann commented 2 months ago

@getusha @thienlnam PR https://github.com/Expensify/App/pull/41834 is ready

melvin-bot[bot] commented 1 month ago

This issue has not been updated in over 15 days. @thienlnam, @zanyrenney, @getusha, @DylanDylann eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

thienlnam commented 1 month ago

We're still working through this

melvin-bot[bot] commented 4 weeks ago

This issue has not been updated in over 15 days. @thienlnam, @zanyrenney, @getusha, @DylanDylann eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!