[$500] Room mention - Room mention is highlighted when different room is created from whisper

lanitochka17 commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.76 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/issues/40857

Action Performed:

Go to staging.new.expensify.com
Go to any room
Mention a non-existing room (#hello) and send it
Edit the message in Step 3 and add another word right behind the room mention (#helloworld)
Save the edit
Click Yes on the whisper room creation message

Expected Result:

The new room mention in edit message in Step 4 will not be highlighted because the mentioned room is different from the room created from the whisper

Actual Result:

The first half of the room mention is highlighted when the room mention is different

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/72c34807-6fe8-4325-8382-78249d5c5b3d

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c628cdc0c39c744f
Upwork Job ID: 1798161042106114048
Last Price Increase: 2024-08-05

Issue Owner

Current Issue Owner: @allgandalf

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 5 months ago

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 5 months ago

We think that this bug might be related to #vip-vsp

melvin-bot[bot] commented 5 months ago

@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 5 months ago

@anmurali Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 5 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01c628cdc0c39c744f

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

anmurali commented 5 months ago

This seems like an edge case so I am going to make it a medium priority bug but if we get someone to fix it, great!

devguest07 commented 5 months ago

Maybe the Whisper component should update the room creation message whenever the message is edited.

melvin-bot[bot] commented 5 months ago

📣 @devguest07! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:
```
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
```

devguest07 commented 5 months ago

Contributor details Your Expensify account email: devguest07@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01020d097e810d1b07

melvin-bot[bot] commented 5 months ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

allgandalf commented 5 months ago

Waiting for proposals …..

melvin-bot[bot] commented 5 months ago

@anmurali @allgandalf this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

allgandalf commented 5 months ago

Waiting for proposals.....

melvin-bot[bot] commented 5 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 5 months ago

@anmurali, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

allgandalf commented 5 months ago

Bumped on slack for proposals

jainilparikh commented 5 months ago

I believe Whisper in this case is created by the backend, and there is nothing we can do from the front-end to fix this. There are no actions (APIs) in frontend that we can use to re-create the whisper.

melvin-bot[bot] commented 4 months ago

@anmurali, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

allgandalf commented 4 months ago

Still waiting for proposals ....

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

NJ-2020 commented 4 months ago

I think the issue is from the backend.

When we mention a non-created room, the Concierge Expensify will ask the user to create the room because it doesn't exist. So when we edit the comment and change the room name, and click yes (before asking us to create a room) to concierge Expensify, the bot doesn't change the room name from the updated comment. For example: The bot asking to create room1 but when we changed the room name to room12, the bot didn't update the room name. So, when we click yes, the bot will wrap the room1 text only and not wrap the 2 last character inside the mention-room tag

But for the functionality wrapping text in the mention room tag is on the backend not on the frontend

melvin-bot[bot] commented 4 months ago

@anmurali @allgandalf this issue is now 4 weeks old, please consider:

Finding a contributor to fix the bug
Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] commented 4 months ago

@anmurali, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

allgandalf commented 4 months ago

@anmurali , do you think we should increase the bounty to get some 👀

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 4 months ago

@anmurali, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

allgandalf commented 4 months ago

@anmurali , what do you think about this?

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

allgandalf commented 4 months ago

bump @anmurali

melvin-bot[bot] commented 4 months ago

@anmurali, @allgandalf Huh... This is 4 days overdue. Who can take care of this?

anmurali commented 4 months ago

Raised it to $500.

melvin-bot[bot] commented 4 months ago

Upwork job price has been updated to $500

huult commented 4 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

The first half of the room mention is highlighted when the room mention is different

What is the root cause of that problem?

We called an API to update a comment. I saw that the text was updated, but the last message HTML mention-report did not update yet. We then called ResolveActionableReportMentionWhisper to resolve the action report mention whisper with the report action ID, but it used the old, not updated text, causing the issue.

What changes do you think we should make in order to solve the problem?

Check the UpdateComment API to see why the text did not update. I believe if the UpdateComment API updates the text correctly, this issue will be resolved

What alternative solutions did you explore? (Optional)

allgandalf commented 4 months ago

Posted on slack for more 👀

melvin-bot[bot] commented 4 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 4 months ago

@anmurali, @allgandalf Huh... This is 4 days overdue. Who can take care of this?

allgandalf commented 4 months ago

Still waiting for proposals...

allgandalf commented 3 months ago

I posted again on the open source channel to ask for proposals, do let me know of the next steps if we do not get new proposals by the next overdue label

FitseTLT commented 3 months ago

BE issue

b4s36t4 commented 3 months ago

I feel this issue is backend.

I'm not sure how backend is resolving the whisper message, we're receiving a new reportAction i.e whisper message with a param reportNames with the mention we've done. After we update the comment we're not receiving or updating the whisper message when we click yes for whisper message we're just sending the reportActionID for the whisper message.

I think we should update the whisper reportAction with the newly updated comment.

Maybe a new API call calling from frontend or backend directly can update the whisper report-action using the updateComment method itself.

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 3 months ago

@anmurali, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

allgandalf commented 3 months ago

still waiting for proposals......

b4s36t4 commented 3 months ago

@allgandalf hope you read the comments above, we think it's backend issue. Are you confident this can be solved from frontend that's why you're waiting for proposals or is there any other reason?!

melvin-bot[bot] commented 3 months ago

@anmurali, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

allgandalf commented 3 months ago

@allgandalf hope you read the comments above, we think it's backend issue. Are you confident this can be solved from frontend that's why you're waiting for proposals or is there any other reason?!

I wanted a FE/upstream fix for this, I want to match the Expected results:

The new room mention in edit message in Step 4 will not be highlighted because the mentioned room is different from the room created from the whisper

But now i'm unsure if this should be fixed on the FE/BE, @anmurali should we put up an internal label here?

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 3 months ago

@anmurali, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Expensify / App