search

Experience-Monks / three-bmfont-text

renders BMFont files in ThreeJS with word-wrapping
http://jam3.github.io/three-bmfont-text/test/
MIT License
789 stars 171 forks source link

Errors as of Three.js r112 #34

Closed JustASquid closed 4 years ago

JustASquid commented 4 years ago

Looks like some deprecations have caused some warnings/errors.

THREE.BufferAttribute: .setArray has been removed. Use BufferGeometry .setAttribute to replace/resize attribute buffers

THREE.BufferGeometry: .addAttribute() has been renamed to .setAttribute().

mikehenrty commented 4 years ago

I believe this will need to be fixed upstream: https://github.com/Jam3/three-buffer-vertex-data/issues/3

A fixed was proposed, but I haven't tested it: https://github.com/Jam3/three-buffer-vertex-data/compare/master...ilidio:master

FredericBriolet commented 4 years ago

Hi all,

I'm using three.js r114, and indeed the erros come from three-buffer-vertex-data. I tried using Ilidio's version of three-buffer-vertex-data, errors were gone but the text wasn't visible (maybe I was doing something wrong).

Anyway I used this fork of three-bmfont-text instead and it worked nicely: https://github.com/dmarcos/three-bmfont-text

It uses another fork of three-buffer-vertex-data: https://github.com/dmarcos/three-buffer-vertex-data

Just replaced three-bmfont-text in my package.json: from: "three-bmfont-text": "^2.3.0" to: "three-bmfont-text": "dmarcos/three-bmfont-text#1babdf8507"

Thanks dmarcos!

HexaField commented 4 years ago

I have created some pull requests that fix these issues.

mattdesl commented 4 years ago

Thanks, this is finally fixed in version 3. I had to bump as a major since it proved too difficult to support both new and old versions of ThreeJS simultaneously, which is why this issue dragged on so long. One downside is that with the newer version of ThreeJS, you have to re-create typed arrays to update text, instead of having the possibility of modifying an existing typed array.