Closed jmschrack closed 2 years ago
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Did you test your solution?
I tested all the provided samples in Edge, Chrome, and Firefox. They all worked fine. š
Three-bmfont-text is incompatible with ES6 classes. See: https://github.com/Jam3/three-bmfont-text/issues/46
var Base = THREE.BufferGeometry function TextGeometry (opt) { Base.call(this) ... } inherits(TextGeometry, Base);
was changed to
class TextGeometry extends THREE.BufferGeometry { constructor(opt){ super(opt); ... } }
Aditional comments:
Accidentally made this from my master branch instead of my dev branch. Closing and reopening as https://github.com/Jam3/three-bmfont-text/pull/49
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Did you test your solution?
I tested all the provided samples in Edge, Chrome, and Firefox. They all worked fine. š
Problem Description
Three-bmfont-text is incompatible with ES6 classes. See: https://github.com/Jam3/three-bmfont-text/issues/46
Solution Description
was changed to
Side Effects, Risks, Impact
Aditional comments: