F5Networks / f5-common-python

Python SDK for configuration and monitoring of F5® BIG-IP® devices via the iControl® REST API.
https://f5-sdk.readthedocs.org
Apache License 2.0
262 stars 134 forks source link

Filter/redact sensitive information from iControl Rest debug logging #1151

Open sjberman opened 7 years ago

sjberman commented 7 years ago

https://github.com/F5Networks/f5-icontrol-rest-python/blob/v1.3.0/icontrol/session.py#L255

The iControl Rest library logs anything and everything that passes through, as seen at the line above. This can be useful information, however if sensitive information such as custom ssl profiles are uploaded to the BIG-IP, the data is logged at the debug level. There should likely be some sort of filter or redacted text in the case of sensitive data being sent to the BIG-IP via iControl Rest.

wojtek0806 commented 6 years ago

@caphrim007 any thoughts?