FCP-INDI / C-PAC_templates

Templates and atlases that aren't included in Neuroparc and are packaged in C-PAC
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

🐛 Glasser Template Output Incomplete #23

Open nimzodisaster opened 9 months ago

nimzodisaster commented 9 months ago

Describe the bug

Output for Glasser Atlas contains time-series for 180 ROIs but atlas has 360.

To reproduce

No response

Preconfig

Custom pipeline configuration

No response

Run command

No response

Expected behavior

360 ROI timeseries for Glasser Atlas, not 180

Acceptance criteria

360 ROI timeseries for Glasser Atlas, not 180

Screenshots

No response

C-PAC version

Version 1.8.4.dev

Container platform

No response

Docker and/or Singularity version(s)

No response

Additional context

No response

sgiavasis commented 6 months ago

Hi @nimzodisaster,

Thanks for the bug report. We are releasing v1.8.7 this week and have begun development for v1.8.8, where we will be focusing heavily on stability and robustness, and we will look into this issue.

kjamison commented 4 months ago

I just encountered this problem as well, and can confirm that the output should have 360 regions. This is probably related to the fact that some of the files distributed with the Glasser atlas have both left and right hemisphere labeled 1-180, but it should be 1-180 for right hemisphere, and 181-360 for left hemisphere.

shnizzedy commented 4 months ago

This issue is probably related to / a duplicate of https://github.com/neurodata/neuroparc/issues/32, or at least will be resolved when we replace our Neuroparc copy of Glasser to get around that issue.