search

FDH2 / UxPlay

AirPlay Unix mirroring server
GNU General Public License v3.0
1.55k stars 78 forks source link

Why don't use hostname as default server name? #16

Closed PetrusZ closed 3 years ago

PetrusZ commented 3 years ago

There is a PR for antimof/UxPlay, https://github.com/antimof/UxPlay/pull/42, why don't use it?

I think is a good idea to use hostname as default server name.

fduncanh commented 3 years ago

Why would it be useful to default to hostname?

fduncanh commented 3 years ago

This (utsname) would be very linux specific.

edit: OK it seems to be in BSD and macoS too.

fduncanh commented 3 years ago

OK I see the point.

I've implemented it, and pushed UxPlay to v1.36 as this is a significant change. Thanks for the suggestion.

PetrusZ commented 3 years ago

Great!👍🏻

fduncanh commented 3 years ago

@PetrusZ

I thought this through again, and instead decided to append @hostname (hostname = utsname.nodename) to UxPlay, or whatever was selected with -n option, so default choice would be seen as UxPlay@hostname

It's now released as UxPlay 1.37