search

FESOM / tripyview

Triangular plotting for FESOM2
MIT License
4 stars 3 forks source link

template_hmesh.ipynb does not work with ref_path #129

Closed JanStreffing closed 2 weeks ago

JanStreffing commented 2 months ago

It appears that template_hmesh.ipynb does not work when ref_path, ref_name and ref_year are set in the config yaml. The reason is that we are trying to use ref_cinfo.copy() here: https://github.com/FESOM/tripyview/blob/efd6f445c09f4a7481c60f56e83bcc0269ad75f6/templates_notebooks/template_hmesh.ipynb#L328 While the creation of ref_cinfo is commented out above: https://github.com/FESOM/tripyview/blob/efd6f445c09f4a7481c60f56e83bcc0269ad75f6/templates_notebooks/template_hmesh.ipynb#L254-L260

I tried removing the comments, but that did not work either. I little be more needs to be either added or removed here I think.

patrickscholz commented 2 weeks ago

hope fully fixed with push https://github.com/FESOM/tripyview/pull/144