search

FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
100 stars 27 forks source link

revise text about column ordering #175

Closed grahamegrieve closed 7 months ago

grahamegrieve commented 12 months ago

Column ordering: ViewDefinition runners MUST produce columns in the same order as they appear in the views.

I think 'views' isn't the right word in that sentence.

Also, given that not all runners produce ordered sets of columns, I think that this needs some qualification

johngrimes commented 10 months ago

The text has changed since this issue was created, it now reads:

ViewDefinition runners MUST produce output in the same order as the column structures seen in the ViewDefinition instances.

The other perhaps pertinent change has been to require column names within view definitions.

In the context of this, why is it desirable to require deterministic column ordering in the output?

johngrimes commented 7 months ago

I think this has now been resolved by #208.