search

FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
92 stars 26 forks source link

Fix nested union test expectations #212

Closed johngrimes closed 6 months ago

johngrimes commented 6 months ago

I updated the expectations of the "union > nested" test, as I think they are incorrect.

My understanding is that unionAll is supposed to have inner join semantics, similar to forEach. This means that if an expression is not matched, the resource should be dropped from the result.

johngrimes commented 6 months ago

This change is actually not right, after taking another look at the processing model I think the original test case is fine.

See: https://chat.fhir.org/#narrow/stream/179219-analytics-on-FHIR/topic/Nested.20union.20test.20expectations

I've updated our implementation and am withdrawing this.