FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
92 stars 26 forks source link

Contributing guide is missing a step, I think. #214

Closed barabo closed 6 months ago

barabo commented 6 months ago

I'm following the contributing guide, and I'm failing on step 2.

Click to see my terminal output. ``` @barabo ➜ /workspaces/sql-on-fhir-v2 (master) $ ./scripts/_updatePublisher.sh Checking internet connection /workspaces/sql-on-fhir-v2/input-cache/ does not exist create it?y IG Publisher NOT FOUND in input-cache or parent folder Will place publisher jar here: /workspaces/sql-on-fhir-v2/input-cache/publisher.jar Ok (enter 'y' or 'Y' to continue, any other key to cancel)?y Downloading most recent publisher to Input Cache - it's ~100 MB, so this may take a bit % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 183M 100 183M 0 0 140M 0 0:00:01 0:00:01 --:--:-- 178M Update scripts? (enter 'y' or 'Y' to continue, any other key to cancel)?y Downloading most recent scripts % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 6630 100 6630 0 0 81851 0 --:--:-- --:--:-- --:--:-- 81851 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 671 100 671 0 0 7063 0 --:--:-- --:--:-- --:--:-- 7063 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 36 100 36 0 0 423 0 --:--:-- --:--:-- --:--:-- 418 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 33 100 33 0 0 336 0 --:--:-- --:--:-- --:--:-- 336 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 667 100 667 0 0 10934 0 --:--:-- --:--:-- --:--:-- 10934 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3603 100 3603 0 0 27930 0 --:--:-- --:--:-- --:--:-- 27930 @barabo ➜ /workspaces/sql-on-fhir-v2 (master) $ ./scripts/_genonce.sh Checking internet connection... Online Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 FHIR IG Publisher Version 1.5.16 (Git# 2dd71bdfb01d). Built 2024-01-30T12:42:56.541Z (27 days old) Detected Java version: 21.0.2 from /usr/local/sdkman/candidates/java/21.0.2-ms on Linux/amd64 (64bit). 1984MB available dir = /workspaces/sql-on-fhir-v2, path = /usr/local/rvm/gems/ruby-3.2.3/bin:/usr/local/rvm/gems/ruby-3.2.3@global/bin:/usr/local/rvm/rubies/ruby-3.2.3/bin:/vscode/bin/linux-x64/81725794264e4c0fddbc1b3b728013744ae90840-insider/bin/remote-cli:/home/codespace/.local/bin:/home/codespace/.dotnet:/home/codespace/nvm/current/bin:/home/codespace/.php/current/bin:/home/codespace/.python/current/bin:/home/codespace/java/current/bin:/home/codespace/.ruby/current/bin:/home/codespace/.local/bin:/usr/local/python/current/bin:/usr/local/py-utils/bin:/usr/local/oryx:/usr/local/go/bin:/go/bin:/usr/local/sdkman/bin:/usr/local/sdkman/candidates/java/current/bin:/usr/local/sdkman/candidates/gradle/current/bin:/usr/local/sdkman/candidates/maven/current/bin:/usr/local/sdkman/candidates/ant/current/bin:/usr/local/rvm/gems/default/bin:/usr/local/rvm/gems/default@global/bin:/usr/local/rvm/rubies/default/bin:/usr/local/share/rbenv/bin:/usr/local/php/current/bin:/opt/conda/bin:/usr/local/nvs:/usr/local/share/nvm/versions/node/v20.11.0/bin:/usr/local/hugo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/share/dotnet:/home/codespace/.dotnet/tools:/usr/local/rvm/bin Parameters: -ig . Start Clock @ Monday, February 26, 2024, 4:38:20 PM Coordinated Universal Time (2024-02-26T16:38:20Z) Build FHIR IG from /workspaces/sql-on-fhir-v2/. (00:00.114 / 00:00.114, 21Mb) API keys loaded from /home/codespace/.fhir/fhir-settings.json (00:00.008 / 00:00.122, 21Mb) Package Cache: /home/codespace/.fhir/packages (00:00.007 / 00:00.130, 21Mb) Run Sushi on /workspaces/sql-on-fhir-v2 (00:00.007 / 00:00.137, 21Mb) Sushi couldn't be run. Complete output from running Sushi : (00:00.028 / 00:00.165, 22Mb) Note: Check that Sushi is installed correctly ("npm install -g fsh-sushi". On windows, get npm from https://www.npmjs.com/get-npm) (00:00.001 / 00:00.166, 22Mb) Exception: Cannot run program "sushi" (in directory "/workspaces/sql-on-fhir-v2"): error=2, No such file or directory (00:00.001 / 00:00.168, 22Mb) Publishing Content Failed: Cannot run program "sushi" (in directory "/workspaces/sql-on-fhir-v2"): error=2, No such file or directory (00:00.001 / 00:00.169, 22Mb) (00:00.001 / 00:00.170, 22Mb) Use -? to get command line help (00:00.001 / 00:00.171, 22Mb) (00:00.001 / 00:00.172, 22Mb) Stack Dump (for debugging): (00:00.001 / 00:00.174, 22Mb) java.io.IOException: Cannot run program "sushi" (in directory "/workspaces/sql-on-fhir-v2"): error=2, No such file or directory at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1170) at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1089) at java.base/java.lang.Runtime.exec(Runtime.java:681) at org.apache.commons.exec.launcher.Java13CommandLauncher.exec(Java13CommandLauncher.java:61) at org.apache.commons.exec.DefaultExecutor.launch(DefaultExecutor.java:279) at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:336) at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166) at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:153) at org.hl7.fhir.igtools.publisher.FSHRunner.runFsh(FSHRunner.java:91) at org.hl7.fhir.igtools.publisher.Publisher.initialize(Publisher.java:2400) at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:974) at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:12505) Caused by: java.io.IOException: error=2, No such file or directory at java.base/java.lang.ProcessImpl.forkAndExec(Native Method) at java.base/java.lang.ProcessImpl.(ProcessImpl.java:295) at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:225) at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1126) ... 11 more ```

So, I think the instructions should mention or link-to instructions for installing sushi.

barabo commented 6 months ago

See #215

johngrimes commented 6 months ago

215 has now been merged, closing.