search

FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
100 stars 27 forks source link

updates to the README and gitignore #215

Closed barabo closed 8 months ago

barabo commented 8 months ago

Some minor readability improvements, TODOs, and extra instructions for new contributors.

I added info for installing sushi, and for ignoring the downloaded sushi scripts.

barabo commented 8 months ago

For some context behind the proposed changes to the Contributing instructions, I wanted to try to run this in a GitHub Codespace, which didn't have sushi installed already. Also, this environment is unable to preview the built IG content using the open instruction.

I resolved this by using npm to install fsh-sushi and http-server. By using http-server, the Codespace does the correct thing by opening the fresh IG a new browser tab, serving the local content for inspection.

rbrush commented 8 months ago

Changes LGTM. I'm happy to merge unless others see anything amiss.

barabo commented 8 months ago

Go ahead and merge for me - I don't have write access to the repo. Thanks for the quick review!