search

FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
103 stars 28 forks source link

Invalid Type Name in unit test - fn_join "join with no value - default to no separator" #231

Closed awalley-ncqa closed 4 months ago

awalley-ncqa commented 7 months ago

The unit test "join with no value - default to no separator" contains a column definition which has the type "name". I believe this is meant to be "string"

{
  "resource": "Patient",
  "select": [
    {
      "column": [
        {
          "path": "id",
          "name": "id",
          "type": "id"
        },
        {
          "path": "name.given.join()",
          "name": "given",
          "type": "name" <--- Invalid type name (?) should be "string" I think
        }
      ]
    }
  ]
}
arjun commented 7 months ago

This is a bug - NR

arjun commented 7 months ago

Write test for this. Expect error.

johngrimes commented 4 months ago

Fixed in 3cd35b55665d6f964f9d98376894d612c9f09a2a.