FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
92 stars 26 forks source link

Added OHS implementation #235

Closed bashir2 closed 4 months ago

bashir2 commented 4 months ago

The format of the test-result.json file is slightly different, e.g., it has a result.reason field for tests that we skip. I'll update the documentation in a follow-up PR. This PR also removes the duplicated implementations.json to fix #237.

johngrimes commented 4 months ago

If you want to preview what the test report will look like, you can run the app inside the test_report up locally.

bashir2 commented 4 months ago

If you want to preview what the test report will look like, you can run the app inside the test_report up locally.

Thanks for the tip; I ran the app locally and also updated some of the instructions. As a side effect, I also fixed #237 and updated documents accordingly.

bashir2 commented 4 months ago

You've got the test result directly within the test object:

{
  "name": "basic attribute",
  "passed": true
}

It needs to be nested inside a "result" field, like this:

{
  "name": "basic attribute",
  "result": {
    "passed": true
  }
}

This is now fixed in the latest version of our test report.

bashir2 commented 4 months ago

Thanks @johngrimes for merging this. Looking at the implementations page it cannot fetch Pathling's test report. It seems it throws a CORS error; can you please take a look?