FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
92 stars 26 forks source link

added Safhire implementation #253

Closed kayyagari closed 1 month ago

kayyagari commented 1 month ago

This PR contains details of a new implementation.

johngrimes commented 1 month ago

Hi @kayyagari,

Thanks very much for sending this in!

I think that the test report file has some problems with the format, would you mind validating it against the JSON schema file?

This is the output I get:

[
  {
    instancePath: '/fn_extension.json',
    schemaPath: '#/patternProperties/.*/required',
    keyword: 'required',
    params: { missingProperty: 'tests' },
    message: "must have required property 'tests'"
  }
]
kayyagari commented 1 month ago

@johngrimes I have fixed the report, please review it whenever you get a chance. Thank you very much for your time and effort.

johngrimes commented 1 month ago

Hi @kayyagari,

This is all working now, I will merge this.

Would you be interested in coming along to our meeting and sharing what you have done, and some info on the intended use case?

We meet every Tuesday 3pm US Eastern time.

kayyagari commented 1 month ago

@johngrimes thank you.

Would you be interested in coming along to our meeting and sharing what you have done, and some info on the intended use case?

Absolutely, will join the upcoming one.