search

FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
92 stars 26 forks source link

Replace metadata elements with inheritance of CanonicalResource #259

Closed johngrimes closed 2 weeks ago

rbrush commented 3 weeks ago

Since this is a logical model, rather than a resource, it's not clear to me that we should inherit from CanonicalResource (despite the common fields).

Is there precedent for other logical models inheriting from CanonicalResource?

GinoCanessa commented 2 weeks ago

While I don't know that there is anything documented that specifically prohibits that inheritance, I cannot make sense of what it would mean.

Also, I know that my tooling would fail to resolve the inheritance tree fairly spectacularly.

johngrimes commented 2 weeks ago

I thought that this was a pretty straightforward omission, but it seems like it is a bit more complicated than that.

Perhaps in the interest of simplicity we abandon this PR for now, and revisit if/when we progress from the logical model?