FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
105 stars 29 forks source link

Create diagram with Layered view #95

Closed dkapitan closed 1 year ago

dkapitan commented 1 year ago

I would be happy to have a go at creating a diagram of the diagram of the layers to be used here.

Just wanted to check whether it is helpful to do so using the Archimate standard as follows:

Please let me know what you think and I should be able get out a first version in a matter of days.

bkaney commented 1 year ago

Awesome, here was my very early start at this, happy to share the Miro if you want:

image
bkaney commented 1 year ago

FWIW, we will likely change "Annotation Layer" to "Data Layer" see: https://chat.fhir.org/#narrow/stream/179219-analytics-on-FHIR/topic/Implementation.20Guide.20UX

dkapitan commented 1 year ago

@bkaney Here is my first go at it. Let me know (and be brutally honest) whether this is helpful. I was trying to scratch my own itch, since I needed to specify in more detail how the SQL-on-FHIR stack would play out in the project I am working on.

I was trying to have a bit more details to illustrate the different options that there are (also see https://github.com/FHIR/sql-on-fhir-v2/discussions/75). The diagram now shows the most likely scenario's but there are a couple more. For example, with a duckdb runner you can work on a file-based data layer and even on some RDBMS data layer (PostgreSQL integration). But I think the most important thing is to have a visual overview of the description of the layers, otherwise the visual gets too busy. At a later stage, we could add similar layered views for each specific use-case / runner implementation.

I have made this using Archi, the source code is here.

sql-on-fhir-layers png

bkaney commented 1 year ago

This is great! I think your nice details here could be interpreted as part of the spec (and not as examples). I wonder if we could try out a version that is a bit more simplified and abstract; perhaps a summary of each layer: 1) what does the layer do, and 2) what are the use-cases of the layer

What do you think?

dkapitan commented 1 year ago

Happy you like it, and have actually grown to like Archimate for this type of work. Indeed what you can do is create different views on the specifcation:

I saw you took up the helm for the UX part of the IG, happy to help and contribute. Am quite tied up for the coming days, will pick it up after that.

dkapitan commented 1 year ago

@bkaney Just wanted to check: shall a work on a separate branch and create a new PR with the diagrams + explanations? I saw the discussion on the overall structure of the pages, so please let me know what structure to follow.