FHIRType / workshop

Healthcare Provider Data API
GNU General Public License v3.0
0 stars 0 forks source link

Welcome, PacificSource! #63

Closed trentonyo closed 6 months ago

trentonyo commented 6 months ago

Fix PacificSource Endpoint

ASSOCIATED ISSUES:

  • Resolves #54
  • Closes #56
  • PacificSource endpoint now passes all tests on home machine

Description

🥳 PacificSource Endpoint: We can now query PacificSource! Re-run the configMaker script (instructions here) to get the latest configuration, then boot up a query and see what PacificSource has to say about it!

🆕 HTTP Client mode: In order to facilitate the above, we now have a new method of sending queries. We use the lower-level alternative to requests in HTTP.client. This option has been propagated across the configuration maker so it can be applied to any endpoint, if that endpoint has certain qualities or needs!

✅ API Multiple Responses: Fixed issue #56 with a small patch, search for one of the providers in the #resource channel to see responses from more than one endpoint.

Definition of Done

trentonyo commented 6 months ago

Addendum: Damn it.

The GitHub Actions worker still tries an SSL handshake, and turns out my laptop does too.

These fixes only pass on my desktop, and I would assume also Kevin's home computer. @kecarman74 , perhaps there's something common to your environment and my environment that we could specify in the HTTP.client request? It's definitely using HTTP 1.1, but maybe there's even more to it

ImgyeongLee commented 6 months ago

Nice insecure connection