search

FRC1076 / 2019-Competition

Code for 2019 Competition
2 stars 1 forks source link

ElevatorAttendant must initialize elevateToHeightRate in constructor #54

Closed mcolinj closed 5 years ago

mcolinj commented 5 years ago

This avoids a crash if the variable is accessed before the PIDController updates it.

Also, when the the PIDController is disabled, the value should be reset to 0. This prevents a "janky" response when the attendant is reused, and a left-over value remains in the instance variable. If it is accessed before the PIDController updates it, it could cause some trouble.

mcolinj commented 5 years ago

Fixed while working on changes in pull request #62.