search

FRC1076 / 2019-Competition

Code for 2019 Competition
1 stars 1 forks source link

Added sonar and vision sensors #68

Closed VeeBallbach closed 5 years ago

VeeBallbach commented 5 years ago

Replaced remoteSensors.py with separate files for sonar and vision. I'm not sure if everything is done correctly and/or completely, but at least most of the necessary code should be there.

VeeBallbach commented 5 years ago

The sonar, vision, and robot.py currently use ports for testing, not the real ports

mcolinj commented 5 years ago

We should probably try to test this code on the robot (using the proper addresses) and some kind of vision and sonar before we integrate it into master. However, we should invite @cmonk to use it for his vision testing work. Maybe you can be around when he is testing to provide some support as needed. For now, you can keep pulling in updates from master so you are up-to-date, and so the final version will merge easily.

mcolinj commented 5 years ago

This is shaping up nicely. I'd like you to do one more thing

We need to get the udp_channel into the mix before this collapses to master, otherwise everyone's everything is going to break. Not sure what you prefer. We could add the file to the repo and work from there (installing it into a library in at season's end), or, we could get the latest changes incorporated into the library, update the requirements.txt, send a note out to everyone to install the new library, and then commit this relying on the library.

thanks,

matthew