[VERSION TRACK] v3.4.1 Known Issues & Bugs

[jtsage]

Known Bugs - v3.4.1

This issue is an umbrella issue to keep track of bugs in the current version. You can reply directly here, but opening a new issue would make life easier for us.

Issue List (included in 3.4.1)

• [x] (3.4.1) Misspelling of 2 new fill types from straw harvest (or variants) 954c80174d3c9cb6687f6cef8295b2e9f684d079
• [x] (3.4.1) Dumb logic typo for base game placeables (they all have the "parent file" warning background) 72f1325edd55c42336d4d76d66243c5d7f03893d
• [x] (3.4.1) Game running indicator not hiding as expected. 0d06dc5c9632db7530cb49c3fae3c17e032c78bf
• [x] (3.4.1) Chart Units missing on mod detail pages ab26a44e1d71990bc363908b1804d71824f99103
• [x] (3.4.1) Unusable mods not visually different in mod list f1142e69a011449b199a9b9aee13eb48423c2097
• [x] (3.4.1) Documentation was very, very outdated. ce3383290acb48c3e9d996e950d91bc055134698, d61773d9a1120ef81e03d33407bb26ae15d9aba5, 4d5daab5a5d744c5d2cc97868bee0685ba851fa6, 855b55dcd321f0382a712d87d158828a47efdb30

Issue List (included in 3.5.0-RC1)

• [x] (3.4.91) Add logic trap to remove /x86/ from game path on base game browser. #211 c663d5296a0b477d7c33c90a98dfc4f5261daae3
• [x] (3.4.91) Download display was wonky, mis-placed text, and the speed calculation failed at 1,000Mb. Also allow https:// in server URL's. 91b1d5f42f1245a334b17bdaca9cde4cfaaa42e4
• [x] (3.4.91) Visual indication needed on mini-mode when game is running. 7850107a44dabd7b8a10d789e607ab16de988957
• [x] (3.4.91) Add option to drag-and-drop a CSV collection export to the main window to compare it to current collections. Uses the same visual interface as the savegame compare tool. #208 7850107a44dabd7b8a10d789e607ab16de988957, 278fcc2d03cac68144870688a9397eeb7c4ba5c1
• [x] (3.4.91) Deep link of attacher joints in mod detail display broken 4ecd658d32931f898975fb8aeaa70921fe04f91a
• [x] (3.4.91) Button list for collections was getting long, prefer icon for savegame checker. ab1a8f3e88277577bd689fee7ca8e015040da1eb
• [x] (3.4.91) Preferences window is clunky - #212 0a5fbcc6b713b4ca26f2ff8a266f9a7dd1728be6, f02cd6e1d44ef9d1c8834582f585100e76ba1de8
• [x] (3.4.91) Collection Management in separate window is clunky - #213 0a5c3387224cc42419fb94d38888ac7bcf808eeb
• [x] (3.4.91) Code duplication in preload files, some can probably be shared. fd045036185a7d075f3f0537e9f2981df1ec2a2c
• [x] (3.4.91) Disabling older FS does not disable XML file checking #214 0c18f1312cbab5136279ada40bfe5be842ceabd4
• [x] (3.4.91) Game Polling (status bubble) should be optional. 1b630fa0de123e699df4d4b71c67af1ba5ca6a4f
• [x] (3.4.91) Collection details/notes page should visually resemble settings page. 193cc6dc3f392c46c5f1ae40595fb9094a1ca1b6

Issue List (included in 3.5.0-RC2)

• [x] Missed some log spam for game polling 15760ebd63aff25dbb97f9d9eb9693433eb8d2da
• [x] Checkbox on preferences / collections details is unclear, use a custom option diff 3bf6245777fff8e255059c7e462946bf16bf5fee
• [x] Visual overlap on gamelog screen #215 7eff21642c5f95c6833f75b7af92419e69c4c46a
• [x] Right click to copy/move/delete all selected would be nice ae205dcf5126f6f96e26ee51fedc62a7a19e463c
• [x] Not happy with the spacing / alignment of side buttons since change to configurable font-size f7523ac2a2d818bd3d679142ca8af01bd68115a6
• [x] Right click on a savegame had an icon code, not text. fix in l10n files. f23e09e8d536b62c1d54385ef80b23cccf7dd671

Issue List (included in 3.5.0-RC4)

• [x] Add GitHub Cat to button 4ba2740fd0d7a2e4c1e3df7fa74ae7d3844aba3e
• [x] Add Icons to right click menus 228c6d607961159d011cbeddafa0805ff885c91c
• [x] Hide Crop Calender JSON display when not applicable, turn into a copy-to-clipboard button otherwise. fa6a3bb3ef9293514149cf6aefe9208600b183c5, d5a7a70a48f0ed9cd5c145d683136c30bb89a1ec
• [x] Erase search box icon is off-center when font-size is not default. b3be9c1e81db9083cbdc7af4f618350a9cedfa0f
• [x] Open log file in explorer button not working a0a7d0e9cc037cd73cce231be6fe83f036bd71a7
• [x] FSG Bot integration (server status) would be pretty spiffy. e2dee3aaa0c52522b9ce443a7df9cf5c38dc1e16, 39eca690958f57e5b275bf45d1f3f1ec3cc319d8 howto
• [x] Need light variant (black) context menu icons as well. 0bcca1558e46daf43d86e3b514f7f457d467f15c, 2e4c05db35ff50a5fb569e41fe78bdef451520bd
• [x] Support for "Through the Years" mod - display the vehicle year in the details, if it is known. 29262f26a9ebe287d41d2f51c548dcca3e04836c

Issue List -- Included in 3.5.0-RC6, most in #218

• [x] Context menus follow the system theme, not the MA theme - this is probably wrong. 44823e21334f08ceb96d214d08990b0e85bdaf5b
• [x] A first-time setup wizard sure would be cool
• [x] The move/copy/delete/import windows shouldn't be separate windows, move them where they belong
• [x] Updates/changes got unwieldy again, refactor main file for readability and organization
• [x] Add season temperature detection for maps
• [x] Many visual changes to use inset-box model from preferences pane
• [x] CTRL+Space shortcut works in mini window now
• [x] drag-and-drop should not fire when file operation or preferences change is in progress
• [x] New tag filtering system using "advanced" radio buttons - I think it makes more sense as to what is happening
• [x] Add a "compare all" button to base game sub categories (e.g. "Large Tractors")
• [x] Try and plug a memory leak in the icon converter / generator
• [x] Share savegame compare results with the main window for as long as the savegame compare window remains open.

Issue List - Included in 3.5.0-RC7

• [x] Fix basegame graphs again
• [x] Catch modlook fail from missing folder/file
• [x] Make depends / required by submenus useful
• [x] automate HTML testing
• [x] Add icons to tray menu
• [x] Show dropdown when collection has multiple maps
• [x] Detect malicious mods (LUA that nukes your mods, saves and settings)

Special Note: there is no way I didn't break a few things on this RC, at least 1 or 2 more are going to be forthcoming before 3.5.0-RELEASE.

Progress

• [x] BugFix 3.4.1 Released : v3.4.1
• [x] 3.5.0-RC1 Released : v3.5.0-RC1
• [x] 3.5.0-RC2 Released : v3.5.0-RC2
• [x] 3.5.0-RC3 Released : v3.5.0-RC3
• [x] 3.5.0-RC4 Released : v3.5.0-RC4
• [x] 3.5.0-RC5 Released : v3.5.0-RC5
• [x] 3.5.0-RC6 Released : v3.5.0-RC6
• [x] 3.5.0-RC7 Released : v3.5.0-RC7

[vitalii2011]

This is probably overkill for non-maps:

[jtsage]

Oh, good catch - yeah, it should hide it if it doesn't have it. honestly, it should probably always be hidden behind a click-gate, it's pretty specialized as to who needs it :)

[vitalii2011]

P. S. In addition to maps with a “calendar”, as you know ) , there are mods like Crop Calendar Manager https://www.farming-simulator.com/mod.php?lang=en&country=us&mod_id=275437

[vitalii2011]

And we need a cat. ))) git.zip

[vitalii2011]

Probably, there is space left here for command icons like in Windows Explorer?

[jtsage]

P. S. In addition to maps with a “calendar”, as you know ) , there are mods like Crop Calendar Manager https://www.farming-simulator.com/mod.php?lang=en&country=us&mod_id=275437

Haha. Yes indeed. I actually spoke to Jos when he released this to nicely let him know I wasn't going to directly support it in MA :) It's a very cool mod though.

[jtsage]

Probably, there is space left here for command icons like in Windows Explorer?

I don't know. But that looks rather nice with the icons, and I will find out for sure.

[jtsage]

[vitalii2011]

I don't understand why the "heart" is there. They are not necessarily looking for what they “like”. But this, of course, is just my opinion. )

As always, you are doing much better and on a larger scale than expected.

[jtsage]

It's to match the button on the side - I think I picked it because it was the only option that wasn't just the spy glass. I'm open to other ideas as to what could mean "modhub" - I came up pretty empty.

[vitalii2011]

Just a no-frills magnifying glass. And it doesn’t matter that the same will happen for another “Find”. Search is search. )

[vitalii2011]

By the way – “binoculars”?

[vitalii2011]

"Add Icons to right click menu" is not available in 3.4.93.

[vitalii2011]

"Hide Crop Calendar JSON display when not applicable" - in the same place, but in the form of a button:

[jtsage]

"Add Icons to right click menu" is not available in 3.4.93.

huh. that's odd. I have it, on the work computer I just installed on (not my work machine)

So, something is odd here. I'll try and reproduce.

[jtsage]

"Hide Crop Calendar JSON display when not applicable" - in the same place, but in the form of a button:

Lol. this one is on me, I hid the header, but the button isn't a child of the header. my bad.

[vitalii2011]

huh. that's odd. I have it, on the work computer I just installed on (not my work machine)

I only looked in the Search field.

[jtsage]

LOL! ok. they are in fact there, probably. But they are white. I didn't do any sort of theme checking on it. I'll get one that :)

[vitalii2011]

But they are white.

That's what I assumed. )

[vitalii2011]

Is it possible to navigate by clicks or the ability to copy the title?

[jtsage]

Yeah, I can make those do something - tell me more on your idea - open up the details page for the clicked dependency / requirement? (I have to check if those lists are populated only with existing mods - it might be everything, even if the "requirement" is not met)

[vitalii2011]

• Indeed, some scripts are not on ModHub. Then just copy the name. It seemed like: scroll the list to the mod whose name you clicked on.
• There is an option: search for the missing mod on the Internet, but for me, for example, this is not suitable - Google search in my Republic is blocked by providers. Then you will need a choice of search engines, and this is unnecessary.

[jtsage]

that makes sense. ok. I'll do a "scroll to the mod" if it exists. If not, I'll have it populate the system clipboard with the name of the mod, along with a little bubble popup that says it was not found, and it's available to paste into whatever of your choice.

[vitalii2011]

It would probably be more convenient if these category labels were displayed in the main list:

[jtsage]

Oh. yeah, I see what you mean. Ok. I'm gonna need to think about how to achieve that - the results in the savegame compare window are pretty transient, but I should be able to populate them back to the main window.

While you are around - do you have any thoughts on the copy/move/delete operation being a separate window? Would it better serve as a overlay to the main interface?

I had hoped to get 3.5.0 released today - however, I've gotten involved in some style changes in some windows, and adding an initial setup wizard, so that is not going to happen. I hope to have a new RC build late tonight though. Fair warning, there are more than a few new translation strings for the initial setup wizard that I will add as soon as I can take decent screenshots :)

[vitalii2011]

While you are around - do you have any thoughts on the copy/move/delete operation being a separate window? Would it better serve as a overlay to the main interface?

I think this is not necessary. For what? If I get you right.

[jtsage]

These windows.

My thoughts for making it a overlay of the window:

• less extra windows opening. (both easier and slightly harder from a programming perspective)
• I'm using an "always on top" flag on those - but I don't have the option to make it always on top of only other Mod Assistant windows - I find that frustrating sometimes.

My thoughts against making it an overlay:

• The way it is now, you can still scroll in the main window if you move it out of the way if you have a reason to need to do that.

[vitalii2011]

I have never moderated a group game. Perhaps such an option is useful/convenient for such moderators, but I have no idea about it.

• Replying to an incorrectly translated message. )
• Probably not necessary/superfluous/not very convenient.

[jtsage]

It would probably be more convenient if these category labels

This one was kinda hard. But it is tied to the open save game compare window, when you close that, the tags disappear again. They also only appear on the collection you have compared to (limitation in how I'm doing the comparison, when these tags go back to the main window it's too late to figure out if they were not present in the compared collection but do exist in the new one you are viewing)

as per usual, I'm still messing with exactly how the tags are displayed. Alas, it is also too late to add them to the filter buttons next to the search box.

[vitalii2011]

Sorry, I forgot ( , which can be done like this:

P. S. Video capturing all the necessary windows below

[vitalii2011]

It might make sense to add a "Selected" button:

[jtsage]

aye. it's been a space problem - but part of the update is a rework to how the two filter buttons appear, so there is likely room there now

[jtsage]

sweet, thank you - I had thought that was what you meant - added to my working copy. I have a bunch to do as far as updating screenshots and documentation, but I hope to have the updated translations to crowdin and a test build sometime tonight (UTC-05:00)

[vitalii2011]

Video capturing all the necessary windows:

https://github.com/FSGModding/FSG_Mod_Assistant/assets/41552153/1910d451-1ee8-402c-a092-93608d553ca9

[vitalii2011]

3.4.96 - strange/not always the close button “Select game version” works: when the window is minimized, with several clicks it expands the window to the full screen and only then works:

https://github.com/FSGModding/FSG_Mod_Assistant/assets/41552153/4759dfd0-8f81-44b9-b9d1-48b2795a1432

• Here's another place where there are no icons for menu items ) :
• I didn’t find anything “good” anymore. )))
• Liked the maps icon:

[jtsage]

I really should already be sleeping - but thanks, I'll take a look in the morning closer.

As to that close button - on closer inspection, it looks like it only works if you click exactly on the white X (not the background doesn't count). I'll adjust to the more standard button style.

Good catch on the context menu icons, I forgot that one was there.

As to the map icons - yes. I'm still playing with a way to reasonably display more than one - as of right now, it will show a map icon if there is one, and only one map in the folder. Maybe a hover/dropdown combo or something if it has more than one would look nice

[vitalii2011]

• This huge planet: when someone just wakes up, someone else's day will already be over.
• Maybe it’s possible/easier to add a mod to “Selected” when click it?

[jtsage]

ok, I think this is pretty clever...

Thumbs Up - you have it, in the same collection, all is well - clicking on it will do what you described - select it in the main window, with the search field filled to just that mod.

Thumbs Down - you don't have it anywhere, the mod short name (everything before the .zip) will be copied to your keyboard

Spy Glass - you have it, but it's in the wrong collection - clicking it will bring up the "Find All" window with that mod pre-selected so you can grab it from the collection of your choice and copy it around if you want.

[jtsage]

[vitalii2011]

[jtsage]

yeah, you're probably right - I wasn't sure I could mess with those after I created them, but in getting the theme right I had to figure out how to do just that anyway

[vitalii2011]

If you can change the background behind the image with the tag name:

[jtsage]

multiple-map dropdown for collections with more than 1

[jtsage]

If you can change the background behind the image with the tag name:

I can change the background, yes - where I am having trouble is in using the standard red/yellow/green traffic light design to communicate what is really happening in this dropdown.

The buttons correlate pretty closely to the RFC standard definitions : https://datatracker.ietf.org/doc/html/rfc2119

The PIN is the mod MUST have that tag (more than one pin, it MUST have all of them)

The SLASHED EYE is the mod MUST NOT have that tag (more than one slashed eye, it MUST NOT have any of them)

The OPEN EYE is the mod MAY have that tag (it does not need to, it's provided as a visual opposite of the SLASHED EYE)

Finally, the PIN causes the OPEN EYE to be forcibly toggle "on"

I can see how red would correlate well to the SLASHED EYE - but the green state could be either the PIN or the OPEN EYE, and that's where my confusion comes in.

[vitalii2011]

раскрывающийся список с несколькими картами для коллекций, содержащих более 1

• Great!
• Are these targets for a mini-game?

[jtsage]

heh. Bot integration with the bot our community leader wrote - it's really a multi-player specific feature, but it's kinda cool

https://fsgmodding.github.io/FSG_Mod_Assistant/fsgbot.html

In the case you posted, that would be our 16 regular realistic servers along with the 2 "co-operative" ones.

[vitalii2011]

I can change the background, … my confusion comes in.

I'll think about it. But it’s hard, because I’m not used to it. )

[vitalii2011]

When working with this list, I feel like clicking on the picture with the tag name, but now it’s not a button. And that would probably be more convenient. But and now everything is fine.

[jtsage]

I could add a click there - maybe have it just cycle to the "next" setting? show->hide->limit to->repeat?

[vitalii2011]

I think it’s normal now, but you know better.