search

FWGS / xash3d-fwgs

Xash3D FWGS engine
1.58k stars 240 forks source link

In the xash3d-fwgs-win32-i386 version from 26.10.2024, the tooltips at the bottom of the screen do not work #1861

Closed usergithub64 closed 3 weeks ago

usergithub64 commented 4 weeks ago

In the xash3d-fwgs-win32-i386 version from 26.10.2024, when hovering the mouse over the menu items, the tooltips at the bottom of the screen do not work and the menu items are shifted to the bottom of the screen: xash3d_2024_10_27_14_32_10_518 xash3d_2024_10_27_14_32_21_578 In the xash3d-fwgs-win32-i386 version from 15.10.2024, everything works fine: xash3d_2024_10_27_14_30_58_508 xash3d_2024_10_27_14_31_15_255

a1batross commented 4 weeks ago

It's an intentional change, as WON menu never had them.

Not only that, in most cases they aren't helpful at all, stating the obvious help text like "Done" button just says "Go back to previous menu".

They're only left in menu that were added by us, like Touch and Gamepad menus, as they often have new settings, where a little help string might be useful.

a1batross commented 4 weeks ago

These tooltips aren't helpful for touchscreen users either, as they only show up on mouse hover and there is nothing similar to this action on a touchscreen.

BTW, I'm open to suggestions for implementing better short help/description.

a1batross commented 3 weeks ago

Feel free to open a new issue with suggestions for better help strings.

usergithub64 commented 3 weeks ago

Why are the options in the main menu shifted to the bottom of the screen, like in the first screenshot?

a1batross commented 3 weeks ago

It's the same, original WON menu does this.

usergithub64 commented 3 weeks ago

Can you tell which commits revert these fixes? (so that the menu items show up as in the 15.10.2024 version and the tooltips show up as in the 15.10.2024 version)

a1batross commented 3 weeks ago

Yeah, you don't actually need to build an engine for this.

All you need is to revert this and this and compile ONLY mainui_cpp and put it in cl_dlls directory.

menu.dll located in alongside client.dll always have precedence over built-in one.