Facepunch / sbox-issues

176 stars 12 forks source link

[Hammer] Ambient Color and Sky Color are black with shadows disabled #2972

Open yuberee opened 1 year ago

yuberee commented 1 year ago

Describe the bug

Working on a game that uses dynamic ambient light, because of the style we're going for, we won't be needing shadows being cast. But disabling shadows will turn any dark area into pitch black, regardless of Sky Color or Ambient Color.

This is the settings I'll use: image And this is what it looks like with image image

While this is what it looks like with image image

Don't mind the red, as I've used it to make it easier to see the difference. Ignoring the shadows being cast for obvious reasons, setting "Cast Shadows" to "No" is only going to use the sun's color, which looks ugly unless that's the style you're going for, which should still be an option.

To Reproduce

  1. Open any Hammer Map
  2. Set the light_environment to not use baked light
  3. Set "Cast Shadows" to "No"
  4. Mess around with Sky Color, Sky Intensity, and Ambient Color
  5. Set "Cast Shadows" to "Yes" to see differences

Expected behavior

Instead of dark areas being pitch black, it should use the Ambient Color like it normally would.

Media/Files

No response

Additional context

We're going with a retro style in a forest, so not only does disabling shadows boost FPS, it also makes sense for a PSX-style game. Unfortunately right now it's either pitch black or full bright.

wheatleymf commented 1 year ago

Can confirm this is still happening at the current moment. All dark spots and shadowed areas appear pitch black regardless of any option as long as you have shadow casting disabled, which is quite inconvenient