search

Facepunch / sbox-issues

175 stars 12 forks source link

[Shadergraph] Shader preview fails to compile resulting in broken preview #4130

Closed QuackCola closed 10 months ago

QuackCola commented 10 months ago

Describe the bug

When attempting to use shadergraph any changes i make to either a new or existing shadergraph shader are not visible in the Preview window. I do notice Compile Failed being printed in the console each time i click on the compile button.

To Reproduce

  1. Open Shadergraph
  2. Open an existing shadergraph shader or create a new one.
  3. make some changes and compile and notice that none of your changes will visible in the preview viewport. Also notice the Compile Failed error being printed in the console.

Expected behavior

The compile should succeed and thus any changes to the graph should be visible on the preview model in the Preview Viewport.

Media/Files

https://github.com/sboxgame/issues/assets/23345567/54aa8a21-02ae-4bba-bd9f-6383cb678e01

Additional context

No response

handsomematt commented 10 months ago

should be 🆗 now

QuackCola commented 10 months ago

should be 🆗 now

I can confirm its working as expected now. Thanks!