Facepunch / sbox-issues

175 stars 12 forks source link

S&box hard crashes when disabling a GameObject with a Map Instance component #4518

Closed CarsonKompon closed 9 months ago

CarsonKompon commented 9 months ago

Describe the bug

Game hard crashes with this log: Log.log

To Reproduce

image

Expected behavior

The map should disappear, similarly to how it works when you disable the Map Instance component (which does work): image

Media/Files

No response

Additional context

No response

garrynewman commented 9 months ago

Does the map have a 3d skybox? Has this started happening in the last few days?

CarsonKompon commented 9 months ago

Does the map have a 3d skybox? Has this started happening in the last few days?

The map has a 3d skybox. Honestly not sure if it started recently because I don't think i've tried doing it before today.

MrBrax commented 9 months ago

this is very recent, it happened to me yesterday. worked fine a week ago or more

handsomematt commented 9 months ago

Probably my 3d skyboxes, I'll get to the bottom of it

handsomematt commented 9 months ago

I can't get this to happen anymore, let me know if it's fine for you.

MrBrax commented 9 months ago

crashes for me when enabling the gameobject again but on this pc i have a 2gb gtx 770 so it might just be an oom ctd

handsomematt commented 9 months ago

that is certainly a low amount, I suppose I can check if you have a log file, mdmp files, steamid64

in the meanwhile, does it work okay for you @CarsonKompon with a normal amount of vram

MrBrax commented 9 months ago

even on my 8gb vram machine it still crashes to desktop when re-enabling it, so unfortunately not fixed

seems to be an issue with the isceneworld.setpvs function or deeper in the stack

handsomematt commented 9 months ago

what map are you testing with

MrBrax commented 9 months ago

https://asset.party/brax/newcity2

could it be too heavy?

handsomematt commented 9 months ago

that was hard to find, it kept crashing my debugger - should be flawless now

MrBrax commented 9 months ago

nice, works now.