[ModelDoc] Right Click - Create Model Not Automatically Creating LODs

Jammie3d commented 8 months ago

Describe the bug

When exporting models I usually name my LODs in blender as model_lod0, model_lod1 etc so that once I import it into s&box they are automatically set up in ModelDoc.

This seems to have broken pretty recently as it was working last week.

New vmdl's are also created with "Globally Replace All Materials In Model" ticked and a PhysicsHullFromRender that's not usually there.

To Reproduce

Download the example FBX suzanne.zip
Extract in a sbox project folder
Right Click the fbx in the sbox asset browser and select Create model...
Save the new vmdl and open in ModelDoc

Expected behavior

After creating a model there should be LODGroups for each LOD level and a RenderMeshFile for each LOD level with names for each one.

Media/Files

No response

Additional context

Video of how it used to work here: https://wiki.facepunch.com/sbox/automatic_model_setup

I don't mind the automatic PhysicsHullFromRender being added.

garrynewman commented 8 months ago

I changed the workflow here and missed that it used to do these things.

I didn't like how it just opened modeldoc, and how it didn't actually create a model, it felt messy.

We should look at building the new model better.

### Tasks
- [ ] In VModelBuilder parse fbx
- [ ] Add LODs if detected

ShadowBrian commented 8 months ago

Could be good to iterate over the materials it's asking for and letting you select them instead of just the blanket white material set to replace all of them, can be confusing.

aylaylay commented 8 months ago

It should be adding all the stuff it did before now

Jammie3d commented 8 months ago

Seems to be working nicely now, thanks!

Facepunch / sbox-issues