Open Gmod4phun opened 1 month ago
I have a feeling this is related to a JSON deserialization issue we're having where it won't deserialize to the default value of the property, it'll use the default value of the type.
Unless I'm missing something, the default for bool should be false, but it is true, so I suspect it does indeed use the default of the property, since when you add a fresh Branch node in the shadergraph, it will have IsAttribute checked.
Describe the bug
Having an older material with an older shader created in shadergraph, I noticed recently that it did not work correctly once I recompiled the shader after the reverse-z update. Found out that the Branch node is now by default an Attribute, and not an UI option. This is probably a thing since IsAttribute was added to the Branch node in https://github.com/Facepunch/sbox-issues/issues/5475
This breaks older materials that relied on it being a UI option in the material editor. I noticed it when my material was no longer grayscale because of the branch node quietly changing to attribute.
To Reproduce
Expected behavior
Most likely have the older shadergraphs (the ones that did not have IsAttribute set on the Branch node in the .shdrgrph) set the IsAttribute to false by default.
Media/Files
No response
Additional context
No response