Facepunch / sbox-issues

176 stars 12 forks source link

Re-Allow non-power of 2 textures in material editor #6246

Open DeltaDesigns opened 1 month ago

DeltaDesigns commented 1 month ago

For?

Material Editor

What can't you do?

In 2022, before the change to Vulkan I believe, non power of 2 textures were allowed in materials (related Issue) I'm not sure if the change to Vulkan broke this change or if it was sometime later but it no longer works. I know it isn't a huge issue to just resize textures but it was a nice quality of life thing.

How would you like it to work?

Allow non power of 2 textures again

What have you tried?

.

Additional context

No response

handsomematt commented 1 month ago

I disabled them again because they were crashing the DXT compressor (even if they're np2 they need to be divisible by 4 still). So I could likely allow them again but add an additional divisible by 4 requirement.. at which point shouldn't you just be using pow2

handsomematt commented 1 month ago

Also the mips would blow

DeltaDesigns commented 1 month ago

I disabled them again because they were crashing the DXT compressor (even if they're np2 they need to be divisible by 4 still). So I could likely allow them again but add an additional divisible by 4 requirement.. at which point shouldn't you just be using pow2

Would it be possible to instead resize them when they get compiled then?