codecov-commenter
commented
2 years ago Codecov Report
Merging #23 (7df533f) into master (6f9652a) will decrease coverage by
9.73%. The diff coverage is49.18%.
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 26.11% 16.38% -9.74%
==========================================
Files 48 45 -3
Lines 1206 1001 -205
Branches 239 191 -48
==========================================
- Hits 315 164 -151
+ Misses 772 751 -21
+ Partials 119 86 -33 | Impacted Files | Coverage Δ | |
|---|---|---|
| ublox-short-range/src/client.rs | 0.00% <ø> (ø) |
|
| ublox-short-range/src/command/data_mode/mod.rs | 0.00% <0.00%> (ø) |
|
| ...lox-short-range/src/command/data_mode/responses.rs | 0.00% <0.00%> (ø) |
|
| ublox-short-range/src/command/data_mode/types.rs | 0.00% <ø> (ø) |
|
| ublox-short-range/src/command/edm/urc.rs | 30.88% <0.00%> (ø) |
|
| ublox-short-range/src/command/ethernet/types.rs | 0.00% <ø> (ø) |
|
| ublox-short-range/src/command/network/types.rs | 0.00% <ø> (ø) |
|
| ublox-short-range/src/command/ping/mod.rs | 0.00% <ø> (ø) |
|
| ublox-short-range/src/command/ping/types.rs | 0.00% <ø> (ø) |
|
| ublox-short-range/src/command/ping/urc.rs | 0.00% <ø> (ø) |
|
| ... and 17 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6f9652a...7df533f. Read the comment docs.
Moving the SocketSet & associated types into it's own crate allows for code re-use in multiple host-based AT networking crates, including ublox-cellular-rs & ublox-short-range-rs.
It also allows for a single SocketSet allocation, that can be moved between multiple drivers in runtime, to facilitate automatic networking fallbacks without double memory usage.