Closed michele-bertoni closed 5 years ago
We removed all the println from tests
Some of them are still there, but it's not a problem. Fixed.
NormalWeaponTest.grenadeLauncherTest
is failing again, please fix asap
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] NormalWeaponTest.grenadeLauncherTest:1060
[INFO]
[ERROR] Tests run: 149, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[ERROR] There are test failures.
we changed on purpose to test a specific situation and forgot to change asserts consequently, fixed
Great! Update your readme file as well, both the implemented features and the instructions to run your jars
done
Great! Update your readme file as well, both the implemented features and the instructions to run your jars
Hi, this issue is to inform you that two of your tests are failing. Moreover, your tests are way too verbose, please delete all the println.
[ERROR] Tests run: 20, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.265 s <<< FAILURE! - in it.polimi.ingsw.model.NormalWeaponTest [ERROR] heatSeekerTest Time elapsed: 0.015 s <<< FAILURE! java.lang.AssertionError at it.polimi.ingsw.model.NormalWeaponTest.heatSeekerTest(NormalWeaponTest.java:849)
[ERROR] grenadeLauncherTest Time elapsed: 0.007 s <<< FAILURE! java.lang.AssertionError at it.polimi.ingsw.model.NormalWeaponTest.grenadeLauncherTest(NormalWeaponTest.java:1031)