search

FedericoGianni / ing-sw-2019-collovigh-contini-dei_cas

Digitalization of the board game Adrenaline from Cranio Creations. Playable with CLI or GUI, within LAN with clients connected via socket or RMI.
0 stars 1 forks source link

Test issues #2

Closed michele-bertoni closed 5 years ago

michele-bertoni commented 5 years ago

Hi, this issue is to inform you that two of your tests are failing. Moreover, your tests are way too verbose, please delete all the println.

[ERROR] Tests run: 20, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.265 s <<< FAILURE! - in it.polimi.ingsw.model.NormalWeaponTest [ERROR] heatSeekerTest Time elapsed: 0.015 s <<< FAILURE! java.lang.AssertionError at it.polimi.ingsw.model.NormalWeaponTest.heatSeekerTest(NormalWeaponTest.java:849)

[ERROR] grenadeLauncherTest Time elapsed: 0.007 s <<< FAILURE! java.lang.AssertionError at it.polimi.ingsw.model.NormalWeaponTest.grenadeLauncherTest(NormalWeaponTest.java:1031)

FedericoGianni commented 5 years ago

We removed all the println from tests

michele-bertoni commented 5 years ago

Some of them are still there, but it's not a problem. Fixed.

keni7385 commented 5 years ago

NormalWeaponTest.grenadeLauncherTest is failing again, please fix asap

[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   NormalWeaponTest.grenadeLauncherTest:1060
[INFO] 
[ERROR] Tests run: 149, Failures: 1, Errors: 0, Skipped: 0
[INFO] 
[ERROR] There are test failures.
FedericoGianni commented 5 years ago

we changed on purpose to test a specific situation and forgot to change asserts consequently, fixed

keni7385 commented 5 years ago

Great! Update your readme file as well, both the implemented features and the instructions to run your jars

FedericoGianni commented 5 years ago

done

Great! Update your readme file as well, both the implemented features and the instructions to run your jars