[Spells] - "On next Cast" triggers being consumed by spells en-route.

[Ashfeenix]

Issue:

Certain abilities or items that cause your "next cast" to be empowered are having these effects consumed by spells that have not yet reached their target.

Known Examples:

[Item] Robes of Insight (940) - [Spell] Insight (18820) [Item] Hand of Edward the Odd (2243) - [Spell] Focus (18803) [Talent] Combustion (11129) [Talent] Elemental Mastery (16166)

How to Reproduce:

.learn 18809 (Pyroblast) .learn 15210 (Lightning Bolt) .learn 18803 (Focus/Hand of Edward proc) .learn 11129 (Combustion) .learn 16166 (Elemental Mastery) .additem 940 (Robes of Insight)

Cast Lightning Bolt on target of your choosing. Directly after casting Lightning Bolt (while spell is still traveling), cast your choice of Focus (18803), Elemental Mastery (16166), or use Robes of Insight. When Lightning Bolt hits, you will see that the buff from the spell that you caster after Lightning Bolt is consumed. The Lightning Bolt neither had a reduced cost, or instant cast time. You can also cast Pyroblast (18809), and use your choice of Robes of Insight, Focus, or Combustion immediately after to see that they are consumed when Pyroblast reaches its target.

[ghost]

Probably related issue: if one casts a projectile spell and then applies something like Arcane Power or a power trinket (or both) while the projectile is already in flight, the projectile already in flight gets the additional damage bonus (where as it should not) and conversely if one casts a projectile spell such that the damage buffs fade while the projectile is in flight, the damage bonus is no longer applied (where as it should be).

Further, if I'm not mistaken mage clearcasting should also proc upon finishing the actual spellcast rather than on projectile hit to target (or more generally at damage being applied, like it currently does) and there are probably a number of related issues where "on spell cast" effects are not actually processed "on spell cast" but rather upon the actual effect being applied. Another example that comes to mind is that actually casting Renew (or other hot) should have a chance to proc trinkets like Blue Dragon but the HoT ticks themselves should not.

The problem with processing "spell cast" events at the wrong time is probably also the reason for the broken infinite blizzard channeling (eg. starting blizzard should have a single clearcast proc chance, not every tick per every mob it hits).

[ghost]

Upon quick testing, this problem applies even to wands: shoot low DPS wand, quick move (to cancel shoot) and equip higher DPS wand, the projectile that hits the target gets the damage from the newly equipped wand, rather than the one that was used for shooting.

[devidao]

I fixed these spells:

• Insight (ID: 18820)
• Focus (ID: 18803)
• Combustion (ID: 11129)
• Elemental Mastery (ID: 16166)

fix coming soon on PTR.

[devidao]

Somewhere missed fix part of DB, I committed it again.

[Forcy]

Fix confirmed on the PTR