FelixReuthlinger / AutoMapPins

GNU Lesser General Public License v3.0
5 stars 3 forks source link

Pin "portal" blocks TargetPortal mod by Smoothbrain- incompatibility #30

Closed arturgaweski closed 3 months ago

arturgaweski commented 3 months ago

Hi, since last update where were added portal pins you cannot use popular mod "TargetPortal" by Smoothbrain due to pin blocking portal icon on map. I can't find config for removing portal pins, can you help me a bit? -edit/ i found pin setting for portal, missed it in r2. Anyway it would be better if by default portal pins were deactivated or there should be added in mod page info about pins possibly blocking usage of mods that use map for teleport or other actions.

sfjuocekr commented 3 months ago

You should be able to add this:

portals:
  categoryConfiguredObjects:
  - portal_stone
  - portal_wood
  isActive: false
  isPermanent: false
  iconName: portal

To remove the nearby and permanent portal pins, I think it is just the permanent pins that obscure the clickable pin used by TargetPortal.

I think AMP shouldn't try to draw on those maps shown from other mods, not sure how feasible this is.

FelixReuthlinger commented 3 months ago

Thanks for the feedback. I did not evaluate this mod with a lot of other mods together. But it might be true that if you use another mod that puts pins for portals on the map, you could or even should deactivate the portal pins in your configs. But if people play the game without another mod putting also pins to the map, they might want to have those activated. The point if I should deactivate the default config shipped with the mod for players using another mod, or leave it active for any player not using another mod for this. I am not sure if it really makes much sense to change the defaults. Since it is up to the player using the mod to adjust to his used mod combination, you can, of course, always deactivate it in your config.

FelixReuthlinger commented 3 months ago

With 2.2.0 I did put portals to default inactive