search

FelixReuthlinger / AutoMapPins

GNU Lesser General Public License v3.0
5 stars 3 forks source link

Custom additions to config not appearing in game #41

Open Morpheus1101 opened 3 weeks ago

Morpheus1101 commented 3 weeks ago

I've added a heap of various Ores to the config an as far as i can tell its entered correctly, logoutput.log shows the vanilla file loads aok, but this does not..SO if you could perhaps shed some light to what im missing here please. Changed it to a .txt instead of yml for purposes of github

FixItFelix.AutoMapPins.categories.modded.txt LogOutput.log

FelixReuthlinger commented 3 weeks ago

If the mod does not print that it did find the file, then it did not find the file. Nothing about the file content being wrong, rather the naming, since it does look for files named like: https://github.com/FelixReuthlinger/AutoMapPins/blob/ccea6b7036c34035c6efd37906b35ecabea42fb7/Data/YamlFileStorage.cs#L35 https://github.com/FelixReuthlinger/AutoMapPins/blob/ccea6b7036c34035c6efd37906b35ecabea42fb7/Data/YamlFileStorage.cs#L73

Besides that some recommendations:

I see you are using permanent a lot, please consider using it less. https://github.com/FelixReuthlinger/AutoMapPins/blob/ccea6b7036c34035c6efd37906b35ecabea42fb7/README.md?plain=1#L14 and following lines

And especially I would not use permanent and groupable together, since there is then no way to decide to remove a part of the pin (like if 3 items were found and you destroy one of them). But this is also kind of explained with the reamde line above that permanent pins need manual removal, no matter what.

Morpheus1101 commented 3 weeks ago

In the config directory i even added those in the attached file into the vanilla cfg file and it still dosent pick them up an im sure the naming of them is correct. I will remove the groupable an permanent though. Guess i'll have to continue working to work out whats going on.

FelixReuthlinger commented 3 weeks ago

Idk, but maybe it is due to using r2... I am using TMM always, since r2 sometimes does screw up things. The file and content of the file need to be found in the folder the game loads, those managers somehow copy around files sometimes. Maybe it does just not have the file in the right spot.

Morpheus1101 commented 3 weeks ago

Most of the ores are added by a mod called BiomeFlora, iirc you need to use wackys to determine what ore spawns in what biome.

Morpheus1101 commented 3 weeks ago

This works as intended in SinglePlayer, however dosent seem to function serverside. I do only have it loaded client side.