search

Felmachersoft / StreamBuffRe

Public issue tracker for StreamBuffRe, see https://streambuffre.com/
5 stars 0 forks source link

Change background color of icons #21

Closed Zero3K closed 6 years ago

Zero3K commented 6 years ago

It would be nice if you changed the background color of the icons used by it to be transparent instead of white (except for the ones that have a border around them).

Felmachersoft commented 6 years ago

The problem with using transparent background for items: thy can't be seen when the menu item is selected, the dark blue of selection and the black of the icon are too similar. Coloring the icons white will have the same problem just for unselected menu items.

Any suggestions what could be done instead?

Zero3K commented 6 years ago

Use icons that have multiple colors in them.

Felmachersoft commented 6 years ago

Won't help, dark colors can't be seen when selected anyway. This does even make the problem worse since every item with every color would need a check if it's visible. And keep in mind the window and selection colors can be changed in windows, thus the items would have to colors always visible.

Zero3K commented 6 years ago

These are the kinds of icons that I am writing about:

menu icons

Felmachersoft commented 6 years ago

Yes, that's what I guessed and you can easily checkout the problem with them: Select the Extension Preference, the blue of this icon can hardly be seen with the dark blue of the selection. Furthermore if you change your selection color to orange, the FlashGot Icon is hard to see and so on.

The other problem is clearly the effort to create such items.

The only feasible option I see right now is using custom drawong of the icons. The idea is: When the MenuItem is not selected the white pixels of them get replaced by the backcolor of the MenuItem thus look like having a transparent background. When selected they are painted originally with the white colors and are still visible.

I will look into custom drawing and if the effort is not too high I will implement it.

Felmachersoft commented 6 years ago

Thankfully it was easier to implement as expected. The result for normal and high contrast settings are following:

normal high contrast

This will be in the next release.

Zero3K commented 6 years ago

Does it also affect the icons shown in the widget list?

Felmachersoft commented 6 years ago

No, cause they should still look like buttons.

Zero3K commented 6 years ago

Okay. By the way, what else is planned for the new version?

Felmachersoft commented 6 years ago

Implemented in 0.5.9.1 as described.