Closed Sejal2801 closed 3 years ago
Hello there!👋 Welcome to moja global!💖
Thank you and congrats 🎉 for opening your first PR on this project.✨
We will review it soon! Till then you can checkout the README.md
for more details on it.
Moja global fosters an open and welcoming environment for al our contributors.🌸 Please adhere to our Code Of Conduct.
Feel free to join us on moja global Private Slack by dropping an email here.👩💻 We would love to hear your interesting ideas and engage in discussions.💖
Moja global is delighted to have you here :)
@Sejal2801 add the issue number in your PR
Okay
On Fri, 18 Jun, 2021, 10:35 AM Khushi Gautam, @.***> wrote:
@Sejal2801 https://github.com/Sejal2801 add the issue number in your PR
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Feminine-Divine/Woodog/pull/76#issuecomment-863757779, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYWCG7C5MHC2EZKXUE6KTTTLHZNANCNFSM4645SIUA .
Sir it has sent by mistake . My issue was #36 i have completed please see that
On Fri, 18 Jun, 2021, 1:21 PM Hari Ram J P, @.***> wrote:
@.**** commented on this pull request.
@Sejal2801 https://github.com/Sejal2801, Can you please make a new PR?
In .vscode/settings.json https://github.com/Feminine-Divine/Woodog/pull/76#discussion_r654216383:
@@ -1,3 +1,3 @@ {
- "python.pythonPath": "env\Scripts\python.exe"
- "python.pythonPath": "C:\Users\sejal\AppData\Local\Programs\Python\Python36\python.exe"
Hi @Sejal2801 https://github.com/Sejal2801, Please Don't change this line in .vscode/settings.json Please look into readme.md https://github.com/Feminine-Divine/Woodog/blob/master/README.md and there you'll get instructions on how to use a virtual environment.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Feminine-Divine/Woodog/pull/76#pullrequestreview-687125321, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYWCE3PJSDB67CD5E2PHTTTL3GJANCNFSM4645SIUA .
@Sejal2801 Yes, You've completed it. That's good :+1: But you have got a lot of changed files in your PR (like woodog-master/
, settings.json
).
That's why Please make a new PR.
or If you're comfortable updating the same branch, you're welcome to do that.
Sir i have not
On Fri, 18 Jun, 2021, 1:33 PM Hari Ram J P, @.***> wrote:
@Sejal2801 https://github.com/Sejal2801 Yes, You've completed it. That's good 👍 But you have got a lot of changed files in your PR (like woodog-master/, settings.json). That's why Please make a new PR.
If you're comfortable updating the same branch, you're welcome to do that.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Feminine-Divine/Woodog/pull/76#issuecomment-863843856, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYWCGEQSWKXFZGVJO2RI3TTL4WBANCNFSM4645SIUA .
Sir i have not done any changes but why are these showing i dont know
On Fri, 18 Jun, 2021, 1:52 PM sejal panjwani, @.***> wrote:
Sir i have not
On Fri, 18 Jun, 2021, 1:33 PM Hari Ram J P, @.***> wrote:
@Sejal2801 https://github.com/Sejal2801 Yes, You've completed it. That's good 👍 But you have got a lot of changed files in your PR (like woodog-master/, settings.json). That's why Please make a new PR.
If you're comfortable updating the same branch, you're welcome to do that.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Feminine-Divine/Woodog/pull/76#issuecomment-863843856, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYWCGEQSWKXFZGVJO2RI3TTL4WBANCNFSM4645SIUA .
@Sejal2801 I will test your PR and then let you know where is the problem
Okay
On Fri, 18 Jun, 2021, 10:02 PM Khushi Gautam, @.***> wrote:
@Sejal2801 https://github.com/Sejal2801 I will test your PR and then let you know where is the problem
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Feminine-Divine/Woodog/pull/76#issuecomment-864153799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYWCALKEP6XVHDHT2UBM3TTNYIHANCNFSM4645SIUA .
I have tested this PR and can't find any issues. so merging this
Mam it was sent by mistake.sorry for that .my pc is not working properly.
On Sat, 19 Jun, 2021, 10:17 PM Khushi Gautam, @.***> wrote:
I have tested this PR and can't find any issues. so merging this
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Feminine-Divine/Woodog/pull/76#issuecomment-864434859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYWCATDNYPEUJYZQTU6G3TTTCZRANCNFSM4645SIUA .
else I don't know why there are changes in settings.py and Readme and code of conduct. Although the purpose of the issue is completed. And no need to say mam :)
Okay 😅
On Sat, 19 Jun, 2021, 10:21 PM Khushi Gautam, @.***> wrote:
else I don't know why there are changes in settings.py and Readme and code of conduct. Although the purpose of the issue is completed. And no need to say mam :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Feminine-Divine/Woodog/pull/76#issuecomment-864435302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSYWCFHQWLR6OIGUOQ7EB3TTTDINANCNFSM4645SIUA .
Congratulations on merging your first contribution to Feminine-Divine!✨ Your code is officially a part of Feminine-Divine now!! 🎉 Please feel free to go with further issues.🙌 Feel free to connect with us by dropping an email here.👩💻 We would love to hear your interesting ideas and engage in discussions.💖
Help a newcomer with their first pull request by providing feedback! This is their first time too, So be as encouraging as possible!😄
Help them setup this project and resolve their queries! 🌸
Create a welcoming or beginner friendly issue for someone else! 😄 🎉
What do these changes do?
Related Issue
Fixes #36
Checklist:
Screenshots or Video or GIF: