search

Fexty12573 / SharpPluginLoader

A C# plugin loader for Monster Hunter World
MIT License
32 stars 2 forks source link

[Bug] Stutters on SPL v.0.0.4.1 #35

Closed GreenComfyTea closed 5 months ago

GreenComfyTea commented 5 months ago

Describe The Problem

I have received a number of reports about stuttering/fps pacing. The longer they played the worse were the stutters. Downgrading to SPL v0.0.4 seems to fix the issue.

Screenshot 1 ![image](https://github.com/Fexty12573/SharpPluginLoader/assets/30152047/7ed53dcc-0ad0-4d5b-ac0d-114f41318578)
Screenshot 2 ![image](https://github.com/Fexty12573/SharpPluginLoader/assets/30152047/687ea35a-b031-4937-aca2-4dad384bb82d)
Screenshot 3 ![image](https://github.com/Fexty12573/SharpPluginLoader/assets/30152047/9f2be3a4-1731-48dc-9c83-a86254987fe1)
Screenshot 4 ![image](https://github.com/Fexty12573/SharpPluginLoader/assets/30152047/c281a536-7650-4998-8221-df625f0360a5)
Screenshot 5 ![image](https://github.com/Fexty12573/SharpPluginLoader/assets/30152047/cdcf1534-1038-482b-9422-ac83fee078f7)

To Reproduce

...

Expected Behavior

No stutters.

Priority

Suggested P2 Priority. The game is unplayable for some players.

Fexty12573 commented 5 months ago

Yikes. Could you ask people to try 0.0.4.1 but have PrimitiveRenderingEnabled set to false in the config? I didn't change many things in 0.0.4.1. And if possible let me know if there are other people that don't have stutters with 0.0.4.

GreenComfyTea commented 5 months ago

Sure will!

There is 1 more person who tried v0.0.4, thou on v0.0.4.1 they encountered the stutters only once, so they are not a reliable example.

Screenshot ![image](https://github.com/Fexty12573/SharpPluginLoader/assets/30152047/165387e6-6a03-439d-85d6-58cc4c51219d)
GreenComfyTea commented 5 months ago

1 person says PrimitiveRenderingEnabled = false fixes the issue.

Screenshot ![image](https://github.com/Fexty12573/SharpPluginLoader/assets/30152047/27cae4e5-bacb-4865-b2d7-d83332b314b5)
Fexty12573 commented 5 months ago

Hmmm ok might be some sort of memory leak then. I did quite heavily revamp that system with 0.0.4.1. Will check when I get home.

Fexty12573 commented 5 months ago

Actually it's probably the GC. I pin a lot of stuff which most likely results in fragmentation so the GC has longer and longer. I'll probably change these arrays to be native memory instead of managed Lists. I will have to make a 0.0.4.2 release anyway so this works. (Or should I just bump it to 0.0.5? Doesn't really matter I guess)

GreenComfyTea commented 5 months ago

There also was 1 another person who said that alt-tabbing was increasing RAM each time. I couldn't replicate it + the person was quite rude, so it might have been just a troll.

Fexty12573 commented 5 months ago

I pushed a potential fix for this in f921f36f9da580c879af2a082375cfd944e3dbb4. If possible, could you test this? If this fixes it I will make a new release either today or tomorrow.

GreenComfyTea commented 5 months ago

I would if I could. But I personally have 0 issues. Probably, my PC just tanks it. I will ask others to try it out.

GreenComfyTea commented 5 months ago

There is 1 more person who tried v0.0.4, thou on v0.0.4.1 they encountered the stutters only once, so they are not a reliable example.

This person says no stutters.

Screenshot ![image](https://github.com/Fexty12573/SharpPluginLoader/assets/30152047/94286a80-d9fc-4970-a126-3f69c8b56360)
Fexty12573 commented 5 months ago

Hmmm. I think I'll just make a 0.0.5 release. Didn't change much in that so it shouldn't require an update on your end.

Fexty12573 commented 5 months ago

Can I close this? Or do the stutters persist?

GreenComfyTea commented 5 months ago

I haven't received any reports about the stutters still being present. Closing it then.