Financial-Times / manage-github-apps

A CLI for managing the repositories of GitHub App installations
MIT License
1 stars 0 forks source link

Use Node v12 #79

Closed andygout closed 4 years ago

andygout commented 4 years ago

After starting the upgrade to Node v14, I noticed that Serverless apps can only go as high as v12 because that is the latest Node version available for AWS Lambda.

I then encountered these excellent points raised by Simon Plenderleith https://github.com/Financial-Times/tooling-helpers/issues/60, which is essentially that packages should ensure compatibility with all version of Node on which they can run, which will be dictated by the apps consuming them.

To do this will increase build time as the process is duplicated for two Node versions, triplicated for three Node versions, etc. (example here). Platforms is currently trying to reduce CI build times so to do this would be undermining all those efforts.

There is no release date yet announced for AWS Lambda v14 (nor its corresponding Docker image), although I’ve been told that Node v12 for Lambda came out about a month after it went into LTS (Node v14 goes into LTS on 27 Oct 2020 so we are looking at ~late Nov 2020).

So all that said, the goal for this current upgrade is to get v12 universally applied to Customer Products repos.