search

Finschia / ostracon

Ostracon, a consensus algorithm, is forked from Tendermint Core. We have added VRF to Tendermint BFT. It adds randomness to PoS Validator elections and improves security.
Apache License 2.0
70 stars 28 forks source link

Fix the order of paremeters in require.Equalf() #534

Closed torao closed 1 year ago

torao commented 1 year ago

Description

In a few code the parameters passed to require.Equalf() and require.Equal() are actual, expected in that order, but they should be expected, actual.

Closes: #XXX

codecov[bot] commented 1 year ago

Codecov Report

Merging #534 (0a018dc) into main (e8f0b19) will increase coverage by 0.06%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #534 +/- ## ========================================== + Coverage 66.03% 66.09% +0.06% ========================================== Files 279 279 Lines 38045 38068 +23 ========================================== + Hits 25122 25162 +40 + Misses 11123 11107 -16 + Partials 1800 1799 -1 ``` | [Impacted Files](https://codecov.io/gh/line/ostracon/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line) | Coverage Δ | | |---|---|---| | [crypto/ed25519/ed25519.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-Y3J5cHRvL2VkMjU1MTkvZWQyNTUxOS5nbw==) | `45.12% <0.00%> (-1.22%)` | :arrow_down: | | [consensus/reactor.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-Y29uc2Vuc3VzL3JlYWN0b3IuZ28=) | `74.66% <0.00%> (-0.45%)` | :arrow_down: | | [mempool/reactor.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-bWVtcG9vbC9yZWFjdG9yLmdv) | `78.57% <0.00%> (ø)` | | | [proxy/multi\_app\_conn.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-cHJveHkvbXVsdGlfYXBwX2Nvbm4uZ28=) | `47.66% <0.00%> (ø)` | | | [crypto/vrf/vrf\_r2ishiguro.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-Y3J5cHRvL3ZyZi92cmZfcjJpc2hpZ3Vyby5nbw==) | | | | [crypto/vrf/vrf\_libsodium.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-Y3J5cHRvL3ZyZi92cmZfbGlic29kaXVtLmdv) | `78.57% <0.00%> (ø)` | | | [p2p/conn/connection.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-cDJwL2Nvbm4vY29ubmVjdGlvbi5nbw==) | `80.38% <0.00%> (+0.57%)` | :arrow_up: | | [consensus/state.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-Y29uc2Vuc3VzL3N0YXRlLmdv) | `73.99% <0.00%> (+0.58%)` | :arrow_up: | | [blockchain/v0/pool.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-YmxvY2tjaGFpbi92MC9wb29sLmdv) | `82.94% <0.00%> (+4.13%)` | :arrow_up: | | [crypto/sr25519/pubkey.go](https://codecov.io/gh/line/ostracon/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=line#diff-Y3J5cHRvL3NyMjU1MTkvcHVia2V5Lmdv) | `43.58% <0.00%> (+7.69%)` | :arrow_up: |